Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky test: Experimental Prompts Show experimental prompt if experiment should be run. Choosing option with link should mark experiment as complete: #71801

Closed
jrieken opened this issue Apr 5, 2019 · 0 comments
Closed

Flaky test: Experimental Prompts Show experimental prompt if experiment should be run. Choosing option with link should mark experiment as complete: #71801

jrieken opened this issue Apr 5, 2019 · 0 comments
Assignees
@roblourens
Labels
engineering VS Code - Build / issue tracking / etc.
Milestone
April 2019

Comments

@jrieken
Copy link
Member

jrieken commented Apr 5, 2019

This test timeouts often, I have pushed a change to disable it

  7 pending
  1 failing

  1) Experimental Prompts Show experimental prompt if experiment should be run. Choosing option with link should mark experiment as complete:
     Error: timeout of 5000ms exceeded. Ensure the done() callback is being called in this test.
jrieken added a commit that referenced this issue Apr 5, 2019
@jrieken
disable flaky test, #71801
c052919
@sbatten sbatten assigned roblourens and unassigned sbatten Apr 5, 2019
skprabhanjan pushed a commit to skprabhanjan/vscode that referenced this issue Apr 6, 2019
@pkoushik0
Merge remote-tracking branch 'upstream/master' into fix-71570
10a4ebf 
* upstream/master: (34 commits)
  Fix markdown.styled regression caused by Uri.parse changes
  Process explorer refactoring
  fix compile error
  fix open workspace uri from cli
  Delete deprecated search provider stub
  test dependenices are devDependencies
  Fix default uri when scheme is file
  disable flaky test, microsoft#71801
  use `readonly T[]` instead of `ReadonlyArray<T>`
  simplify protocol check
  Let enablment service handles local workspace extensions in remote window
  debt - make ext host init data more complete
  Fix colorization tests
  fixes microsoft#71671
  Update grammars
  Add yes-no choice for overwriting existing file for save as
  update distro
  ExtensionEnablementService: - Remove getDisabledExtensions and instead use isEnabled or getEnablementState methods
  Simplify reload action and fix test
  Update distro hash
  ...
@roblourens roblourens added this to the April 2019 milestone Apr 7, 2019
@roblourens roblourens added the engineering VS Code - Build / issue tracking / etc. label May 7, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators May 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
engineering VS Code - Build / issue tracking / etc.
Projects
None yet
Milestone
April 2019
Development

No branches or pull requests
4 participants
@roblourens @jrieken @sbatten @ramya-rao-a