Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cursor jumps unexpectedly to beginning of TS method after using the outline once to jump to a method #72965

Closed
Tanja-4732 opened this issue Apr 27, 2019 · 1 comment · Fixed by #73346
Closed

Cursor jumps unexpectedly to beginning of TS method after using the outline once to jump to a method #72965

Tanja-4732 opened this issue Apr 27, 2019 · 1 comment · Fixed by #73346
Assignees
@joaomoreno @jrieken
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release important Issue identified as high-priority outline Source outline view issues tree-widget Tree widget issues verified Verification succeeded
Milestone
April 2019

Comments

@Tanja-4732
Copy link

Tanja-4732 commented Apr 27, 2019 •
edited

Steps to Reproduce

  1. Have a TypeScript file open (with some code in it)
  2. Use the outline to jump to the beginning of a method
  3. Type something somewhere
  4. Have the cursor jump to the beginning of the previously jumped-to function as soon as you stop pressing keys for .5 seconds

Does this issue occur when all extensions are disabled?

Yes (both in insiders & stable)

Versions

Version: 1.34.0-insider (user setup)
Commit: c1abf79
Date: 2019-04-26T13:39:29.623Z
Electron: 3.1.8
Chrome: 66.0.3359.181
Node.js: 10.2.0
V8: 6.6.346.32
OS: Windows_NT x64 10.0.18356
@jrieken jrieken self-assigned this Apr 29, 2019
@jrieken jrieken added bug Issue identified by VS Code Team member as probable bug outline Source outline view issues labels Apr 29, 2019
@jrieken jrieken added this to the April 2019 milestone Apr 29, 2019
@jrieken jrieken added important Issue identified as high-priority tree-widget Tree widget issues labels Apr 29, 2019
@jrieken
Copy link
Member

jrieken commented Apr 29, 2019

@joaomoreno It seems that the tree send a selection change event after updating children (which happens because markers changed). I will look into a workaround, e.g e.browserEvent being undefined but it seems like a tree issue

Screenshot 2019-04-29 at 10 33 24

@jrieken jrieken added the candidate Issue identified as probable candidate for fixing in the next release label Apr 29, 2019
joaomoreno added a commit that referenced this issue May 6, 2019
@joaomoreno
tree trait model change events should only fire if collection actuall…
12a47bc 
…y changes

fixes #72965
@joaomoreno joaomoreno mentioned this issue May 6, 2019
Merged
joaomoreno added a commit that referenced this issue May 6, 2019
@joaomoreno
tree trait model change events should only fire if collection actuall…
33876f1 
…y changes

fixes #72965
@Tyriar Tyriar added the verified Verification succeeded label May 7, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

@jrieken jrieken

Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release important Issue identified as high-priority outline Source outline view issues tree-widget Tree widget issues verified Verification succeeded
Projects
None yet
Milestone
April 2019
Development

Successfully merging a pull request may close this issue.

Tree trait model change events should only fire if collection actually changes microsoft/vscode
4 participants
@joaomoreno @jrieken @Tyriar @Tanja-4732