Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image View Remembers Zoom #73021

Closed
leegee opened this issue Apr 29, 2019 · 5 comments · Fixed by #73154
Closed

Image View Remembers Zoom #73021

leegee opened this issue Apr 29, 2019 · 5 comments · Fixed by #73154
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@leegee
Copy link

leegee commented Apr 29, 2019

Issue Type: Bug

In VSC, load a small image, zoom in a lot, close the image.
Resize the small image by 10 times.
In VSC, load the resized image.

VS Code version: Code 1.33.1 (51b0b28, 2019-04-11T08:27:14.102Z)
OS version: Windows_NT x64 10.0.17134

System Info
Item Value
CPUs Intel(R) Core(TM) i7-6700 CPU @ 3.40GHz (8 x 3408)
GPU Status 2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
rasterization: enabled
surface_synchronization: enabled_on
video_decode: enabled
webgl: enabled
webgl2: enabled
Memory (System) 15.88GB (8.50GB free)
Process Argv
Screen Reader no
VM 0%
Extensions (15)
Extension Author (truncated) Version
Bookmarks ale 10.4.3
npm-intellisense chr 1.3.0
vscode-eslint dba 1.8.2
githistory don 0.4.6
EditorConfig Edi 0.13.0
rainbow-csv mec 1.0.0
dotenv mik 1.0.1
vscode-typescript-tslint-plugin ms- 1.0.0
vetur oct 0.19.2
github-actions-vscode Oma 2.6.1
rust rus 0.6.1
RustyCode sav 0.19.1
vscode-hexdump sle 1.7.2
sort-lines Tyr 1.8.0
markdown-all-in-one yzh 2.3.1

(1 theme extensions excluded)

@vscodebot vscodebot bot added the terminal Integrated terminal issues label Apr 29, 2019
@Tyriar Tyriar removed the terminal Integrated terminal issues label Apr 29, 2019
@Tyriar Tyriar assigned mjbvz and unassigned Tyriar Apr 29, 2019
@mjbvz mjbvz added help wanted Issues identified as good community contribution opportunities good first issue Issues identified as good for first-time contributors labels Apr 29, 2019
@hunghw
Copy link
Contributor

hunghw commented Apr 30, 2019

I would like to take this. I think we can store more information in cacheKey. In my opinion, we can add the size or add the SHA1 value of the image? @mjbvz Do you have any suggestions?

@cedric05
Copy link
Contributor

cedric05 commented May 2, 2019

can i work on this?

hunghw pushed a commit to hunghw/vscode that referenced this issue May 2, 2019
@hunghw hunghw mentioned this issue May 2, 2019
cedric05 added a commit to cedric05/vscode that referenced this issue May 2, 2019
@cedric05
Copy link
Contributor

cedric05 commented May 2, 2019

i didn't know that @hwhung0111 already started working on this, both prs work. as far as mine considered, i'm resetting scale to 1.

@hunghw
Copy link
Contributor

hunghw commented May 2, 2019

@cedric05 I'm sorry that I didn't reply to you immediately. Do you reset the scale every time you close the image? It makes the editor cannot remember the scale and offset even the image isn't modified.

@cedric05
Copy link
Contributor

cedric05 commented May 2, 2019

yes you are write. let me close mine. 👍

hunghw pushed a commit to hunghw/vscode that referenced this issue May 3, 2019
@mjbvz mjbvz added this to the May 2019 milestone May 3, 2019
@mjbvz mjbvz removed good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities labels May 3, 2019
@mjbvz mjbvz added the bug Issue identified by VS Code Team member as probable bug label May 24, 2019
@Tyriar Tyriar added the verified Verification succeeded label May 29, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants