If getStackTraceRequest returns an empty stack, the Resume button does not work

[DanTup]

If a debug adapter can't provide any frames and returns an empty array, for ex.:

protected stackTraceRequest(response: DebugProtocol.StackTraceResponse, args: DebugProtocol.StackTraceArguments): void {
	response.body = {
		stackFrames: [],
		totalFrames: 0,
	};
	this.sendResponse(response);
}

The Continue button no longer functions - it does not send a continueRequest. The same thing happens if you send an error response. As a workaround (since I have a debugger that can't provide a stack trace yet) I've had to provide a dummy stack frame in order for resume to work (sure, a debugger that can only pause and resume is not terribly useful, but this seems like strange behaviour from VS Code).

	response.body = {
		stackFrames: args.startFrame === 0 ? [
			{
				column: 0,
				id: -1,
				line: 0,
				name: "missing",
			},
		] : [],
		totalFrames: 0,
	};

[isidorn]

If you would like this fixed can you please create a fork of the mock debug with this behavior so I reproduce this issue on my machine. Thank you.

[DanTup]

@isidorn you just need to paste the sample above over stackTraceRequest. I've pushed it here, as well as added logging to make it clear:

https://github.com/DanTup/vscode-repro-73090

The specific change looks like this:

DanTup/vscode-repro-73090@a0a0572

All it does is logs when it stops (on entry), when VS Code asks for a stack trace, and when it gets a continue request, and also returns an empty stack trace.

Run the extension, open a .md file and run it with mock debug. It'll print:

Stopped on entry!
Sending empty call stack!

Now click the Continue button and observe that it never prints "Continue was called!".

Let me know if you ahve any issues reproducing with this.

[isidorn]

Thanks for the nice repro steps.
I have pushed a fix, you can try it out in tomorrow's vscode insiders and let us know if the issue is fixed for you.

[DanTup]

Fix looks good, thanks! :-)

[isidorn]

Thanks, adding verified label.