Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect wording of Outline drawer default message #73214

Merged
merged 2 commits into from
May 3, 2019
Merged

Incorrect wording of Outline drawer default message #73214

merged 2 commits into from
May 3, 2019

Conversation

BaluErtl
Copy link
Contributor

@BaluErtl BaluErtl commented May 3, 2019

Steps to reproduce:

  1. Open an editor tab for a file with a format that parser of Outline drawer supports (eg. .md, .php or .js).
  2. Open another editor tab for a file with a format that parser of Outline drawer does not supports (eg. .yml or .twig).
  3. While the latter editor tab is focused, the text in the Outline drawer reads:

"There are no editors open that can provide outline information."

  1. I do feel that this wording can be considered a bit misleading: in opposition what is currently means, the real fact that there is (at least – in the above scenario – one) editor tab open, which holds data that Outline parser can understand. Although, it's unfocused currently, indeed.
  2. Therefore I suggest wording something similar like this:

The currently focused editor can not provide outline information.

As far as I searched, this message line occurs in code at /src/vs/workbench/contrib/outline/browser/outlinePanel.ts at line :459

  • VSCode Version: 1.33.1
  • OS Version: 10.13.6 (17G6030)

(Ps. issue #73213 was created first before the PR, sorry.)

@jrieken jrieken self-assigned this May 3, 2019
@jrieken jrieken added this to the April 2019 milestone May 3, 2019
@jrieken jrieken added outline Source outline view issues polish Cleanup and polish issue labels May 3, 2019
@jrieken jrieken merged commit b3d37f8 into microsoft:master May 3, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outline Source outline view issues polish Cleanup and polish issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants