Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to write windowsAllowConpty setting #73555

Closed
sbatten opened this issue May 10, 2019 · 2 comments · Fixed by #73562
Closed

Unable to write windowsAllowConpty setting #73555

sbatten opened this issue May 10, 2019 · 2 comments · Fixed by #73562
Assignees
@sandy081 @alexr00
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release verified Verification succeeded
Milestone
April 2019

Comments

@sbatten
Copy link
Member

sbatten commented May 10, 2019

While verifying #73351

I was unable to set the new setting in the settings UI

image
@sbatten sbatten added this to the April 2019 milestone May 10, 2019
@sbatten sbatten added bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release labels May 10, 2019
@sbatten sbatten mentioned this issue May 10, 2019
Closed
@roblourens
Copy link
Member

It seems that having settings that start with "tasks" or "launch" is not allowed, because that is how we identify things in the tasks.json or launch.json?

Tyriar added a commit that referenced this issue May 10, 2019
@Tyriar
Move tasks setting under terminal
d72a4de 
Fixes #73555
@Tyriar Tyriar mentioned this issue May 10, 2019
Merged
@Tyriar
Copy link
Member

Tyriar commented May 10, 2019

Here's a fix for it by just moving the setting under terminal (it's temporary anyway). #73562

alexr00 pushed a commit that referenced this issue May 10, 2019
@Tyriar @alexr00
Move tasks setting under terminal (#73562)
522eb0a 
Fixes #73555
alexr00 pushed a commit that referenced this issue May 10, 2019
@Tyriar @alexr00
Move tasks setting under terminal (#73562)
de9b65e 
Fixes #73555
@alexr00 alexr00 mentioned this issue May 10, 2019
Merged
alexr00 added a commit that referenced this issue May 10, 2019
@alexr00
Move tasks setting under terminal (#73562) (#73566)
57b550c 
Fixes #73555
@RMacfarlane RMacfarlane added the verified Verification succeeded label May 10, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

@alexr00 alexr00

Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release verified Verification succeeded
Projects
None yet
Milestone
April 2019
Development

Successfully merging a pull request may close this issue.

Move tasks setting under terminal microsoft/vscode
6 participants
@roblourens @Tyriar @RMacfarlane @sbatten @sandy081 @alexr00