-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[themes] Put theme configuration to settings.json #7358
Comments
Yes, part of your workbench settings that know about recently opened VSCode input, window sizes, cursor positions. |
Couldn't the theme preview just live update the settings.json? |
Which one? User or workspace settings? |
@aeschli well it would be weird to have a workspace-associated theme, so user. Good point though that there would be a bit of weirdness there. In the end I think it would be good to be able to script your entire vscode setup, themes are the main missing piece in that now that extensions can be installed via the CLI. |
I say you keep the two synced. I'd like to have that ability. |
@Tyriar actually there are situations when theme per workspace makes sense -- I am dealing with the reduced color pallet in the default light+ and dark+ themes which forced me to switch the theme every time I am working with different types of code i.e. workspace. |
When developing extensions, I often have two vscode instances running (sometimes four!) and it would be very helpful if I could quickly distinguish them by assigning each a different theme. |
To add some use cases, I'd like the set the theme per workstation for our environment. I specifically want to mandate a light theme because our users screenshot examples from VSCode and it'd save a lot of toner. But I appreciate that's quite specific. If you add printing support you might also want the ability to use a specific print theme. Perhaps a I think the quickest improvement would be to add the |
I actually found this thread because I was trying to figure out how to get a workspace-associated theme. I'm quite frequently working on multiple projects and being able to associate a specific project's editor window with a particular color would be incredibly helpful |
this would be a killer feature. |
just setting up a new machine after putting my settings.json in source control to maintain across boxes. Having the theme 'settable' from settings.json seems a really worthwhile feature (as well as the icon theme) is automatically installing a theme from the market place if it isn't currently installed (and set in settings.json) too big a step? |
Could it be implemented with an additional setting key called "saveThemeTo" with the values, "user", "workspace" to decide where to make changes by default during live preview? Also, what are the scenarios when the "theme" setting would need to be auto-changed? Just when live-previewing I guess? EDITAnother mechanism can be changing the "theme" in user settings unless a "theme" has been specified in workspace settings. The dirtiest but easiest way would be to obviously add two different menu items. |
Theme configuration is now part of the settings:
It can be configured as a user and also as a workspace setting. |
So i can get all the installed file icons and themes both from iterating in the extensions ? And set current via settings.json ! |
Yes, in the packageJSON you find all contributed themes & icon theme including the path to the theme file and icon theme file. |
Having a
theme
/currentTheme
key that could be set in settings.json would be useful in automatically setting the theme in an automated setup. I'm assuming right now it's handled in local storage or something instead?The text was updated successfully, but these errors were encountered: