Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocompletion is matched against truncated filterText to 54 characters #74133

Closed
jlelong opened this issue May 22, 2019 · 5 comments
Closed
Assignees
Labels
suggest IntelliSense, Auto Complete under-discussion Issue is under discussion for relevance, priority, approach
Milestone

Comments

@jlelong
Copy link
Contributor

jlelong commented May 22, 2019

When providing a list of completionItem with a non empty filterText, it seems that when typing only the 54 first characters of filterText are considered.

Capture d’écran 2019-05-22 à 12 18 40

  1. The first entry has filterText: RoWill2 Rogers, L. C. G. and William Diffusions, Markov processes, and martingales. Vol. 1 undefined. The o of Markov is in position 54 (counting from 0).
  2. The second entry has filterText: RoWill3 Rogers, L. C. G. and Willia Diffusions, Markov processes, and martingales. Vol. 2 undefined. The o of Markov is in position 53 (counting from 0).

When typing o to narrow the completion to Marko, the first entry vanishes.

Capture d’écran 2019-05-22 à 12 18 48

I apologise for not providing a reproducing example but I do not know how to simply provide a list of completions outside of an extension. I noticed this issue in LaTeX Workshop (I am a maintainer of it).

  • VSCode Version: 1.34.0
  • OS Version: OS X 10.14.5
@vscodebot vscodebot bot added the editor-contrib Editor collection of extras label May 22, 2019
@jrieken jrieken added suggest IntelliSense, Auto Complete under-discussion Issue is under discussion for relevance, priority, approach and removed editor-contrib Editor collection of extras labels May 22, 2019
@jrieken
Copy link
Member

jrieken commented May 22, 2019

Yeah - that's the current design and keep things fast. At some point a table is being populated and that's what we cap it. I agree that the limit is arbitrary but there some limit is required. We figured that few programming symbols have names that long and from your sample it seems that you are pushing it will headings...

@jlelong
Copy link
Contributor Author

jlelong commented May 22, 2019

I think those limits should be clearly stated in the API documentation. It would really help extension maintainers.
In my example, we use intellisense to autocomplete bibliography entries and filterText is used to allow global filtering on several fields concatenated together (author, title and journal), hence the length of the field. I am surprising that there is a real efficiency issue forcing you to put such a small limit.

@Bynsu
Copy link

Bynsu commented Jun 25, 2019

Can you please make this limit configurable, at least for custom language extensions, or just make it larger, like at least 128? I'm developing an extension for custom script syntax, and the goal was to allow filtering game NPCs scripts by either their map or part of their full name by making label a string of concatenated name and map. This short limit makes it impossible to do so.

@clsmt
Copy link

clsmt commented Jul 19, 2019

This is really unfortunate. For the scientific community, doing citations is a daily business. This funky behavior basically renders the citation search unusable. I sometimes have to go back to atom just to do citations. I think something small like this can drive people away with time.

I second the proposal of making the limit customizable.

@jrieken
Copy link
Member

jrieken commented Jul 25, 2019

I have increased the limit 128, let's see how far we get with that...

@jrieken jrieken closed this as completed Jul 25, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
suggest IntelliSense, Auto Complete under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

No branches or pull requests

4 participants