Support process.stdout.write from Extension Host to debug output

[octref]

Root cause of #56211

Repro:

/**
 * @param {vscode.ExtensionContext} context
 */
function activate(context) {
	console.log('console.log');
	process.stdout.write('process.stdout.write\n')
}

This is not specific to debug console. process.stdout.write does nothing in extension code.

[octref]

I'm on:
Version: 1.35.0-insider
Commit: 4ca38ce
Date: 2019-05-21T05:17:12.031Z
Electron: 3.1.8
Chrome: 66.0.3359.181
Node.js: 10.2.0
V8: 6.6.346.32
OS: Darwin x64 18.5.0

[alexdima]

It looks like this was done intentionally a long time ago - https://dev.azure.com/monacotools/_git/Monaco/commit/309d5296ab7f09d50f3e04f391617a26fe3335d2?_a=compare&path=%2Fsrc%2Fbootstrap.js

It currently is here --

vscode/src/bootstrap-fork.js

Line 153 in 465d948

process['__defineGetter__']('stdout', function () { return writable; });

I don't know exactly why we did this or if it is now safe to remove...

@bpasero thoughts?

[bpasero]

@alexandrudima yeah I cannot recall for sure, probably some Electron issue which may easily no longer hold true. I think we can try to remove it and see what breaks.

[bpasero]

@joaomoreno hey, do you remember maybe? Looking at EBADF issues on Electron I see some old discussions with you involved: electron/electron#3482 and electron/electron#1471

[joaomoreno]

🤷‍♂️

[bpasero]

Maybe we push this rather early in debt week and not now so close before endgame. I also do not want to overload the Electron 6 update with a potential breaking change such as this one.

[alexdima]

Thanks @bpasero !

[roblourens]

The code change is clearly correct but I'm not sure it makes a difference because as far as I know, the extension host stdout isn't actually going anywhere? When I run process.stdout.write('something\n') in an extension, it doesn't show up in the debug console. And if I use the 'dot' reporter from the original issue, I still don't see the dots, in the debug console or when running in the terminal.

[roblourens]

It does go to the devtools for the window running the extension. It would be on vscode (not the DA) to pass that along to the Debug Console. But if we do that, we would get duplicate messages in the Debug Console.

So I wonder whether the fix you really want is to redirect process.stdout.write to the same place console.log is redirected to. cc @isidorn

[bpasero]

Thanks, I do not think this warrants anymore changes for November.

@octref feel free to check out Robs suggestion if you can make it work.

[bpasero]

This does not seem possible due to nodejs/node#8033

[connor4312]

I did this in a more primitive way in 538988c