Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Comment API contributions #74472

Closed
2 tasks done
RMacfarlane opened this issue May 28, 2019 · 0 comments
Closed
2 tasks done

Test: Comment API contributions #74472

RMacfarlane opened this issue May 28, 2019 · 0 comments

Comments

@RMacfarlane
Copy link
Contributor

RMacfarlane commented May 28, 2019

Refs: #68020

Authors: @rebornix, @RMacfarlane

Complexity: 4

This month, we finalized the new commenting API. Much of this has already been tested and vetted, the change from last month was to support menu contributions to:

  • comments/commentThread/title
  • comments/commentThread/actions
  • comments/comment/title
  • comments/comment/actions

The two "actions" contribution points should render the commands as buttons below the comment text area, at the comment or thread level. We also added these new context keys:

  • commentController, similar to scmProvider, can be used to match the id of a comment controller
  • commentIsEmpty, when the comment text area has no input
  • commentThreadIsEmpty, when the comment thread has no comments
  • comment, which is used to check the contextValue of Comment
  • commentThread, which is used to check the contextValue of CommentThread

Please test that you can contribute commands to these areas, and control when they are shown and enabled with the context keys. Comment API sample for reference: https://github.com/microsoft/vscode-extension-samples/tree/048fa2f156090c43cbe56bc4e2788aa77c091a5d/comment-sample

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants