Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DocumentLink.toolip wrapping #74579

Closed
sana-ajani opened this issue May 29, 2019 · 2 comments · Fixed by #74582
Closed

DocumentLink.toolip wrapping #74579

sana-ajani opened this issue May 29, 2019 · 2 comments · Fixed by #74582
Assignees
@mjbvz @miguelsolorio
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
June 2019

Comments

@sana-ajani
Copy link
Contributor

Testing #74311

OS Version: Windows Enterprise

With wrapping for long tooltips (if the title has space in it)
image

If I have a long link without spacing in it, there's no wrapping and the scroll bar shows up only if you hover by the tooltip.
image

Thoughts on wrapping? @misolori @mattbierner
@mjbvz mjbvz added this to the May 2019 milestone May 29, 2019
@mjbvz
Copy link
Contributor

mjbvz commented May 29, 2019

After thinking about this a bit more, I'd say we should wrap long words / links

@mjbvz mjbvz added the bug Issue identified by VS Code Team member as probable bug label May 29, 2019
@mjbvz mjbvz modified the milestones: May 2019, June 2019 May 29, 2019
@mjbvz
Copy link
Contributor

mjbvz commented May 29, 2019

Pushing to June since the change will effect some core styling

mjbvz added a commit that referenced this issue May 29, 2019
@mjbvz
Fixes #74579
5bbb9c3 
Enable break word for hovers. This prevents super long words from causing wrapping
@mjbvz mjbvz mentioned this issue May 29, 2019
Merged
mjbvz added a commit that referenced this issue Jun 10, 2019
@mjbvz
Merge pull request #74582 from microsoft/dev/mjbvz/fixes-74579
e234ea9 
Fixes #74579 - Enable break word for hovers
@jrieken jrieken added the verified Verification succeeded label Jun 26, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

@miguelsolorio miguelsolorio

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
June 2019
Development

Successfully merging a pull request may close this issue.

Fixes #74579 - Enable break word for hovers microsoft/vscode
4 participants
@jrieken @sana-ajani @mjbvz @miguelsolorio