Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow quickpick to be dismissed via mouse #75174

Closed
josephshin93 opened this issue Jun 10, 2019 · 7 comments
Closed

Allow quickpick to be dismissed via mouse #75174

josephshin93 opened this issue Jun 10, 2019 · 7 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) quick-pick Quick-pick widget issues under-discussion Issue is under discussion for relevance, priority, approach ux User experience issues

Comments

@josephshin93
Copy link

  • VSCode Version: 1.35.0
  • OS Version: OS X Yosemite (Version 10.10.5)

Steps to Reproduce:

  1. Open up Visual Studio Code and open up a folder that has been initialized to be a Git repository.
  2. Click on the branch checkout button at the very bottom left of the window
    vscode-checkout-btn
  3. A dropdown list of branches will appear, you cannot click on any other part of the application to try to close the dropdown list. It can only be closed by hitting the esc key.
    vscode-branch-list
    If I remember correctly, I encountered this issue with the command palate dropdown as well with a previous version of Visual Studio Code. It has been fixed and I can exit the command palate dropdown now by clicking away from the dropdown. I hoped to find an issue report for the past issue as it could be helper for the developers, unfortunately, I could not find an issue report on this topic.

Does this issue occur when all extensions are disabled?: Yes

@vscodebot
Copy link

vscodebot bot commented Jun 10, 2019

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@vscodebot vscodebot bot added the git GIT issues label Jun 10, 2019
@gjsjohnmurray
Copy link
Contributor

This appears to be an intentional change of behaviour that arrived in April. See #71355

@egamma
Copy link
Member

egamma commented Jun 10, 2019

// fyi @misolori another request for a close box

@AlexSZYDLO
Copy link

Can there be an option to disable this? I find very annoying that I have to press esc to close it...

@miguelsolorio miguelsolorio added bug Issue identified by VS Code Team member as probable bug quick-pick Quick-pick widget issues ux User experience issues and removed git GIT issues labels Oct 7, 2019
@miguelsolorio miguelsolorio changed the title Cannot exit list of branches to checkout by clicking outside of the dropdown Allow quickpick to be dismissed via mouse Oct 7, 2019
@miguelsolorio
Copy link
Contributor

This issue should account for all quickpick widgets (branch picker, recents, etc.) to be consistent. One idea is to add a dismiss button (x), but will need to be discussed with the team.

@miguelsolorio miguelsolorio added the under-discussion Issue is under discussion for relevance, priority, approach label Oct 7, 2019
@miguelsolorio
Copy link
Contributor

The original issue (branch picker not closing when clicking outside of the picker) is now fixed, see #82797 for details. Will be closing this one as a duplicate.

@miguelsolorio miguelsolorio added the *duplicate Issue identified as a duplicate of another issue(s) label Oct 21, 2019
@gjsjohnmurray
Copy link
Contributor

I think there's still a good case for adding a "dismiss" button to quickpicks.

@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) quick-pick Quick-pick widget issues under-discussion Issue is under discussion for relevance, priority, approach ux User experience issues
Projects
None yet
Development

No branches or pull requests

5 participants