Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Control checkout Menu does not close, even after Close Repository #82797

Closed
wesinator opened this issue Oct 17, 2019 · 5 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug git GIT issues verified Verification succeeded
Milestone

Comments

@wesinator
Copy link
Contributor

  • VSCode Version: 1.39.2
  • OS Version: macOS 10.14.6

Steps to Reproduce:

  1. git project open
  2. Source Control Providers, click on the branch
  3. checkout menu opens
    image
  4. click Close Repository on the repo
    try to close the menu - doesn't close

Hide and close repository on the pane does not close the menu

How does one close this menu ?

Does this issue occur when all extensions are disabled?: Yes

@gjsjohnmurray
Copy link
Contributor

Does the Escape key do the job?

@miguelsolorio
Copy link
Contributor

miguelsolorio commented Oct 17, 2019

@bpasero @joaomoreno we're seeing a growing number of issues related to this changed behavior in the quick pick (came from #71355). None of our other quick picks behave this way and this creates an inconsistency, which then leads to confusion like the issue above. We even have requests to add a close button to the quick pick because of this (#75174). Can we revisit this change?

@wesinator
Copy link
Contributor Author

Does the Escape key do the job?

no, it did not
(touch bar escape key)

@bpasero
Copy link
Member

bpasero commented Oct 18, 2019

I do not have a strong opinion and we can revert that change. You would need to talk to @chrmarti for showing a close button in quick input.

@joaomoreno
Copy link
Member

Reverted. 👍

@joaomoreno joaomoreno added this to the October 2019 milestone Oct 18, 2019
@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug git GIT issues labels Oct 18, 2019
@roblourens roblourens added the verified Verification succeeded label Oct 30, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug git GIT issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

6 participants