Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Indent guide overlaps with folder with no twistie #75773

Closed
octref opened this issue Jun 19, 2019 · 6 comments
Closed

Indent guide overlaps with folder with no twistie #75773

octref opened this issue Jun 19, 2019 · 6 comments
Assignees
@joaomoreno
Labels
bug Issue identified by VS Code Team member as probable bug tree-widget Tree widget issues verified Verification succeeded
Milestone
June 2019

Comments

@octref
Copy link
Contributor

octref commented Jun 19, 2019

#17777

image

Repro:

Version: 1.36.0-insider
Commit: 6520c22
Date: 2019-06-19T05:18:56.881Z
Electron: 4.2.4
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
OS: Darwin x64 18.5.0
@joaomoreno
Copy link
Member

Great catch!

@joaomoreno joaomoreno added this to the June 2019 milestone Jun 19, 2019
@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug tree-widget Tree widget issues labels Jun 19, 2019
@usernamehw usernamehw mentioned this issue Jun 19, 2019
Closed
@sarahkittyy
Copy link

sarahkittyy commented Jun 20, 2019 •
edited

This was not fixed for me as of the latest VSCode Insiders build? Maybe the fix just wasn't pushed there yet?

image

VSCode Version:

1.36.0-insider
c3fe2d8acde04e579880413ae4622a1f551efdcc
x64

@octref
Copy link
Contributor Author

octref commented Jun 21, 2019

@joaomoreno Can confirm, not fixed for me either on c3fe2d8:

image

@joaomoreno
Copy link
Member

joaomoreno commented Jun 21, 2019 •
edited

Another fix came in yesterday: 5ed30da

It's already out in today's build: 9ff8ae037e8e6109d65e4b5e3eb3dc60cc187e21

@octref
Copy link
Contributor Author

octref commented Jun 21, 2019

Cool, I confirm it's fixed in the latest build.

image

@alexr00 alexr00 added the verified Verification succeeded label Jun 26, 2019
@dubeg
Copy link

dubeg commented Jul 10, 2019

Could we have the guide aligned leftmost to folderIcons?
If not, because the alignment is specified statically (say, n pixels to the left), would it be doable to implement a dynamic alignment without too much trouble?

@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
bug Issue identified by VS Code Team member as probable bug tree-widget Tree widget issues verified Verification succeeded
Projects
None yet
Milestone
June 2019
Development

No branches or pull requests
5 participants
@joaomoreno @octref @dubeg @sarahkittyy @alexr00