Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop event propagation in onEditSettingClicked #75967

Merged
merged 1 commit into from Jul 6, 2019
Merged

Stop event propagation in onEditSettingClicked #75967

merged 1 commit into from Jul 6, 2019

Conversation

jeanp413
Copy link
Contributor

@jeanp413 jeanp413 commented Jun 23, 2019 •
edited

Fixes #75026 (#75947)

@sandy081 sandy081 self-assigned this Jun 24, 2019
@sandy081 sandy081 self-requested a review June 24, 2019 14:30
@jeanp413 jeanp413 mentioned this pull request Jun 28, 2019
Closed
@roblourens roblourens self-assigned this Jul 6, 2019
roblourens
roblourens approved these changes Jul 6, 2019
View reviewed changes
Copy link
Member

@roblourens roblourens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't repro the issue so I can't test the fix, but this looks ok to me and does not seem to break anything

@roblourens roblourens merged commit 10302f5 into microsoft:master Jul 6, 2019
@roblourens roblourens added this to the July 2019 milestone Jul 6, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@roblourens roblourens roblourens approved these changes

@sandy081 sandy081 Awaiting requested review from sandy081

Assignees

@roblourens roblourens

@sandy081 sandy081

Labels
None yet
Projects
None yet
Milestone
July 2019
Development

Successfully merging this pull request may close these issues.

edit button in settings.json only works with right clicking
3 participants
@jeanp413 @roblourens @sandy081