Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No markdown preview button when a file is not named ending with .md #7638

Closed
fenying opened this issue Jun 14, 2016 · 1 comment · Fixed by #12472
Closed

No markdown preview button when a file is not named ending with .md #7638

fenying opened this issue Jun 14, 2016 · 1 comment · Fixed by #12472
Labels
feature-request Request for new features or functionality markdown Markdown support issues
Milestone
September 2016

Comments

@fenying
Copy link

fenying commented Jun 14, 2016

  • VSCode Version: 1.2.0
  • OS Version: Windows 7

Steps to Reproduce:

  1. Open a file named with extension like .txt, only if not .md.
  2. Switch language mode to Markdown.

Now there is no Preview button to switch to Markdown Preview view.
@rebornix
Copy link
Member

I second this. Preview feature is supposed to go with the language mode instead of file extensions. BTW, I think it's also Okay to preview txt files even if it's recognized as plain text, just like what we have in Atom.

@sandy081 sandy081 added the feature-request Request for new features or functionality label Jun 14, 2016
@sandy081 sandy081 assigned jrieken and unassigned jrieken Jun 14, 2016
@jrieken jrieken added the markdown Markdown support issues label Jun 14, 2016
mjbvz added a commit to mjbvz/vscode that referenced this issue Sep 22, 2016
@mjbvz
Show Markdown Preview Button For any File Opened as Markdown
3af6ed4 
Issue microsoft#7638

**Bug**
Open a `.txt` file containing markdown in VSCode. Select the editor language as `markdown` and the highlighing kicks in, but there is no preview button for the file.

**Fix**
Base display of the markdown preview button on `editorLangId` instead of `resourceLangId`.

Closes microsoft#7638
mjbvz added a commit to mjbvz/vscode that referenced this issue Sep 22, 2016
@mjbvz
Show Markdown Preview Menu Button For any File Opened as Markdown
9e28d57 
Issue microsoft#7638

**Bug**
Open a `.txt` file containing markdown in VSCode. Select the editor language as `markdown` and the highlighing kicks in, but there is no preview button for the file.

**Fix**
Base display of the markdown preview button on `resourceScheme` instead of `resourceLangId`.

Closes microsoft#7638
@mjbvz mjbvz mentioned this issue Sep 22, 2016
Merged
@mjbvz mjbvz added this to the September 2016 milestone Sep 26, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature-request Request for new features or functionality markdown Markdown support issues
Projects
None yet
Milestone
September 2016
Development

Successfully merging a pull request may close this issue.

Show Markdown Preview Menu Button For any File Opened as Markdown mjbvz/vscode
5 participants
@rebornix @jrieken @sandy081 @fenying @mjbvz