Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing integrated terminal zoom by mouse scroll #76381

Closed
geekonloose opened this issue Jul 1, 2019 · 11 comments · Fixed by #200639
Closed

Allowing integrated terminal zoom by mouse scroll #76381

geekonloose opened this issue Jul 1, 2019 · 11 comments · Fixed by #200639
Assignees
Labels
feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders terminal Integrated terminal issues verification-needed Verification of issue is requested verified Verification succeeded

Comments

@geekonloose
Copy link

This is similar to #72011, but it would be very convenient to allow zoom for integrated terminals (especially for the small screen). Of course, this can be implemented only on the terminals which are supporting scroll zoom (for ex, git bash, bash etc)

@vscodebot
Copy link

vscodebot bot commented Jul 1, 2019

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@geekonloose geekonloose changed the title Allowing terminal zoom by mouse scroll Allowing integrated terminal zoom by mouse scroll Jul 1, 2019
@vscodebot vscodebot bot added the terminal Integrated terminal issues label Jul 1, 2019
@Tyriar Tyriar added the feature-request Request for new features or functionality label Jul 4, 2019
@Tyriar Tyriar added this to the Backlog milestone Jul 4, 2019
@Tyriar Tyriar added the *out-of-scope Posted issue is not in scope of VS Code label Oct 9, 2019
@vscodebot
Copy link

vscodebot bot commented Oct 9, 2019

This issue is being closed to keep the number of issues in our inbox on a manageable level, we are closing issues that are not going to be addressed in the foreseeable future: We look at the number of votes the issue has received and the number of duplicate issues filed. More details here. If you disagree and feel that this issue is crucial: We are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding and happy coding!

@vscodebot vscodebot bot closed this as completed Oct 9, 2019
@LucaSorvillo
Copy link

Please introduce this required functionality, it is absurd that every time I have to go and change the terminal font in setting...

@Tyriar
Copy link
Member

Tyriar commented Jun 29, 2022

@LucaSorvillo if it's a common thing you do, you could make a simple extension to toggle between two values. In fact there may be generic extensions that do this already.

@LucaSorvillo
Copy link

LucaSorvillo commented Jun 29, 2022

@Tyriar Thanks, I found this extension useful.
It would be even better to be able to do it with the mouse weel as it already happens in editor.

Extension
Name: Terminal Zoom
Id: trybick.terminal-zoom
Description: Control font-size of terminal
Version: 1.7.1
Publisher: trybick
VS Marketplace Link: https://marketplace.visualstudio.com/items?itemName=trybick.terminal-zoom

@Tyriar Tyriar removed the *out-of-scope Posted issue is not in scope of VS Code label Jun 29, 2022
@Tyriar Tyriar reopened this Jun 29, 2022
@Tyriar
Copy link
Member

Tyriar commented Jun 29, 2022

Maybe we should just piggyback off the editor.mouseWheelZoom setting then to avoid adding another setting.

@LucaSorvillo
Copy link

LucaSorvillo commented Jun 29, 2022

Maybe we should just piggyback off the editor.mouseWheelZoom setting then to avoid adding another setting.

I don't know, I think it's really about the UX.
I work all the time with Spring applications and seeing the very long logs in the terminal is not easy 😂

@Tyriar
Copy link
Member

Tyriar commented Jun 29, 2022

@LucaSorvillo some other ideas that might help in the meantime:

  • If it's wrapped lines you can also hit alt+z to toggle "fake wrapping" where we size the terminal's width the the largest wrapped line
  • The Terminal: Set Fixed Dimensions command allows you to do this but to a fixed number of columns
  • You can pipe the output of a command to vscode, I think the syntax is <cmd> | code -
  • Ctrl+shift+up in the terminal should select the output of the previous command to easily copy/paste into an editor

@Tyriar Tyriar added the help wanted Issues identified as good community contribution opportunities label Jun 29, 2022
@LucaSorvillo
Copy link

@Tyriar Thanks again, I'm used to zooming with mouse scroll also because I use it a lot in Windows Terminal ..

@o-l-a-v
Copy link

o-l-a-v commented Nov 29, 2022

If/ when this ever gets implemented (CTRL+scroll for zoom in the terminal), I'd like an option to link the terminal zoom level to the editor zoom level. Like PowerShell ISE does it.

@silv4b
Copy link

silv4b commented Oct 19, 2023

As LucaSorvillo said, there is the extension Zoom terminal, which allows you to increase and decrease the font, once it is installed, you can assign shortcuts, it is not ideal, but it helps a lot.

Tyriar added a commit to Tyriar/xterm.js that referenced this issue Dec 12, 2023
I opted for consistency with the key event handler over our more modern
approach, we can migrate them at the same time if we end up returning
a disposable.

See microsoft/vscode#76381
Tyriar added a commit that referenced this issue Dec 12, 2023
@Tyriar Tyriar modified the milestones: Backlog, December / January 2024 Dec 12, 2023
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Dec 12, 2023
@aiday-mar aiday-mar added verification-needed Verification of issue is requested verified Verification succeeded labels Jan 24, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2024
@aiday-mar aiday-mar added this to the December / January 2024 milestone Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders terminal Integrated terminal issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants