Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panel should announce title when opened #77063

Closed
bhagwatshelke1047 opened this issue Jul 10, 2019 · 5 comments · Fixed by microsoft/azuredatastudio#7206
Closed

Panel should announce title when opened #77063

bhagwatshelke1047 opened this issue Jul 10, 2019 · 5 comments · Fixed by microsoft/azuredatastudio#7206
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug verification-found Issue verification failed verified Verification succeeded
Milestone

Comments

@bhagwatshelke1047
Copy link

Environment Details:
VSCode Version : 1.36.1 (user setup)
OS Version :Win10

Additional Details:
MAS Violated : MAS 1.3.1
Screen Reader Versions : NVDA2019.1.1

Repro Steps:

  1. Open Visual studio code editor
  2. Press ctrl+shift+y
  3. Validate that debugging messages show-up in Debug console
  4. Start NVDA

Actual:
NVDA does not announce the pop up title as 'Debug console' when it is opened using ctrl+shift+y.

This issue is observed in Win10 + NVDA

Expected:
Screen reader should announce the pop up title as 'debug console' when it is opened using ctrl+shift+y.

Recommendations:
Refer below link which is repository of bug fixes code snippets:
https://microsoft.sharepoint.com/teams/msenable/mas/pages/browse-fixes.aspx

User Impact:
Screen reader users will not get that on which page it is being redirected.

MAS Reference:
MAS 1.3.1 -
https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc={54f28d1f-a2d1-4dcd-84e1-5c9b87e8aba4}

Attachment for Reference:
A11y_VSCode_DebugConsole_ScreenReader_NVDA.pptx

@weinand weinand added debug Debug viewlet, configurations, breakpoints, adapter issues debug-console labels Jul 10, 2019
@weinand weinand removed their assignment Jul 10, 2019
@isidorn isidorn changed the title A11y_VSCode_DebugConsole_ScreenReader: NVDA does not announce the pop up title as 'Debug console' when it is opened using ctrl+shift+y. Panel should announce title when opened Jul 10, 2019
@isidorn isidorn added accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues feature-request Request for new features or functionality and removed debug-console debug Debug viewlet, configurations, breakpoints, adapter issues labels Jul 10, 2019
@isidorn isidorn added this to the August 2019 milestone Jul 10, 2019
@gbmeow
Copy link
Contributor

gbmeow commented Jul 29, 2019

@isidorn I will have a look at this

@isidorn
Copy link
Contributor

isidorn commented Jul 29, 2019

@georgebatalinski great, thanks! Ping me on the PR once you create it

@isidorn isidorn added bug Issue identified by VS Code Team member as probable bug and removed feature-request Request for new features or functionality labels Aug 20, 2019
@isidorn
Copy link
Contributor

isidorn commented Aug 20, 2019

To verify make sure that NVDA announces Debug Console when pressing ctrl+shift+y

@mjbvz mjbvz added the verification-found Issue verification failed label Aug 28, 2019
@mjbvz
Copy link
Contributor

mjbvz commented Aug 28, 2019

I may be testing this incorrectly, but I can't get nvda to read Debug Console when using the shortcut

Screen Shot 2019-08-27 at 5 40 32 PM (3)

I tested with a debug session active and when there was no active session. Reopening for additional verification

@mjbvz mjbvz reopened this Aug 28, 2019
@isidorn
Copy link
Contributor

isidorn commented Aug 28, 2019

@mjbvz nice catch. I have only tested it in on the mac.

hunghw pushed a commit to hunghw/vscode that referenced this issue Aug 28, 2019
@alexr00 alexr00 added the verified Verification succeeded label Aug 29, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug verification-found Issue verification failed verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants