Clear disposables in the clearInput method on Disposables #77479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjbvz
reviewed
Jul 16, 2019
|
Fixed. Reverted unnecessary changes. |
|
Rebased the PR on the CURRENT master branch of the official Microsoft vscode repository |
mjbvz
reviewed
Jul 16, 2019
This reverts commit b59ecadf6b1c3c84213b8300df8ba8ce962e6625.
This reverts commit ff8fc9aa75edd7d30d135ef49738754d421fa4fd.
This reverts commit ce17e06dc3849db00e377f221c9e98fc3f11ba6c.
This reverts commit b59ecadf6b1c3c84213b8300df8ba8ce962e6625.
This reverts commit 30d7dc8a3f5ef8a8d8a702da2dc4517a0f64f1d4.
This reverts commit ce404be0b7b7d0c2c5675cf73311f7d5fdc52bfb.
…e, allowing the new method to fit naturally.
|
Everything should be good to go! |
mjbvz
reviewed
Jul 17, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw this pull request on PR #75874, but not only has it not been merged, it has plenty of unresolved conflicts so I made a PR rebased on the most current version of the repository.
This Fixes #75532, and it clears the disposables during clearing text. The code has been refactored to allow this, as to prevent any issues or side effects from arising.
I hope this is useful!