Finalize onDidExecuteCommand-API

[jrieken]

Remaining work is listed here: #1431 (comment). Also, finalise the API

[jrieken]

During the API sync concerns about this API have been raised. The following issues have come up:

• commands are at the heart of almost everything and there is potential to wreck the extension host when doing something every time a command is run
• command arguments aren't API, esp. internal objects (like the explorer model) will leak into the extension host setting expectations that we cannot satisfy

/cc @kieferrm

An alternative to having the onDidExecuteCommand-api would be to allow/accept PRs that extend the core of VS Code. Feature requests that would need this API

• marco recording (run commands in sequence) @hedgerh
• keybindings tutor (teach keybinding when a command was run)

[jrieken]

I have pushed 21de711 that removes the proposed API - as explained in my previous comment. This wasn't an easy decision but there were too many doubts around the usefulness of this API, the performance impact, and accidental leakage of arguments.

However, the internal API is there and we are open to accept features like the "keybindings teacher" or "macro recording" as a core contribution to VS Code.

[hedgerh]

No worries. Thank you for all your help. I may take a crack at it sometime if I have some time. Cheers.

[moshfeu]

Maybe instead of invoking it for each events, a plugin could register to specific events so the callback will be fired only in specific events (PubSub?)

Also, if that API removed, probably it should be mention in the product updates some time.