Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement API for listening to executed commands #66294

Closed
wants to merge 7 commits into from
Closed

Implement API for listening to executed commands #66294

wants to merge 7 commits into from

Conversation

kylecarbs
Copy link

@kylecarbs kylecarbs commented Jan 9, 2019

Implements vscode.commands.onDidExecuteCommand. This does not send args with commands, only the command id and source.

vscode.commands.onDidExecuteCommand((event: vscode.CommandExecutedEvent): void => {
    console.log('We executed the command', event.commandId, event.source);
});

#1431
#26729

@msftclas
Copy link

msftclas commented Jan 9, 2019

CLA assistant check
All CLA requirements met.

@kylecarbs
Copy link
Author

The command source isn't passed around nicely for CommandPalette executions.

https://github.com/Microsoft/vscode/pull/66294/files#diff-66071720e6f855c0bc8b76044df35b3fR36

Suggestions around this would be helpful.

@jrieken
Copy link
Member

jrieken commented Jan 10, 2019

Before diving into the review what is change for? Why is it needed and what do you want to achieve with it?

@jrieken jrieken added the under-discussion Issue is under discussion for relevance, priority, approach label Jan 10, 2019
@jrieken
Copy link
Member

jrieken commented Jan 18, 2019

ping

@prostoandrei
Copy link

@jrieken it would be very helpful for something like this:
#26729

For example https://github.com/halirutan/IntelliJ-Key-Promoter-X for IntelliJ is very useful tool

@jrieken
Copy link
Member

jrieken commented Jan 28, 2019

I understand and like the feature request but this API request a little bug and not without discussion. For instance, the command execution source is a big no-no and I am not yet sure what it means to skip over arguments.

Did it ever occur to you to contribute this to the core and as an extension? Assuming you have this API what UX would your extension contribute?

@jrieken jrieken closed this Feb 26, 2019
@jrieken
Copy link
Member

jrieken commented Feb 26, 2019

no activity, closing

@nolazybits
Copy link

I think the owner of this MR was just trying to get the actual event when a command gets fired.
This will help create extension to promote shortcuts (#26729)

Could you please reopen this?

@jrieken
Copy link
Member

jrieken commented Aug 14, 2019

please see here: #78091 (comment)

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants