New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement API for listening to executed commands #66294
Conversation
The command source isn't passed around nicely for https://github.com/Microsoft/vscode/pull/66294/files#diff-66071720e6f855c0bc8b76044df35b3fR36 Suggestions around this would be helpful. |
Before diving into the review what is change for? Why is it needed and what do you want to achieve with it? |
ping |
@jrieken it would be very helpful for something like this: For example https://github.com/halirutan/IntelliJ-Key-Promoter-X for IntelliJ is very useful tool |
I understand and like the feature request but this API request a little bug and not without discussion. For instance, the command execution source is a big no-no and I am not yet sure what it means to skip over arguments. Did it ever occur to you to contribute this to the core and as an extension? Assuming you have this API what UX would your extension contribute? |
no activity, closing |
I think the owner of this MR was just trying to get the actual event when a command gets fired. Could you please reopen this? |
please see here: #78091 (comment) |
Implements
vscode.commands.onDidExecuteCommand
. This does not send args with commands, only the command id and source.#1431
#26729