Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error: Failed to execute 'removeChild' on 'Node': The node to be removed is not a child of this node. #78184

Closed
jrieken opened this issue Jul 30, 2019 · 1 comment
Closed

Error: Failed to execute 'removeChild' on 'Node': The node to be removed is not a child of this node. #78184

jrieken opened this issue Jul 30, 2019 · 1 comment
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Milestone
July 2019

Comments

@jrieken
Copy link
Member

jrieken commented Jul 30, 2019

https://ticino-errors.azurewebsites.net/Errors?bucketIdHash=ddfe11a8-cfb4-b4d4-acf1-1cebc672b046

Error: Failed to execute 'removeChild' on 'Node': The node to be removed is not a child of this node.
at t.e.dispose (\node_modules.asar\xterm\lib\xterm.js:1:12085) 
at \node_modules.asar\xterm\lib\xterm.js:1:127871 
at Array.forEach ()
at t.dispose (\node_modules.asar\xterm\lib\xterm.js:1:127842) 
at t.dispose (\node_modules.asar\xterm\lib\xterm.js:1:206182) 
at t.dispose (\node_modules.asar\xterm\lib\xterm.js:1:50539) 
at e.dispose (\node_modules.asar\xterm\lib\xterm.js:1:43516) 
/vs/workbench/contrib/terminal/browser/terminalInstance.ts#808:15 (dispose)
/vs/workbench/contrib/terminal/browser/terminalInstance.ts#1084:8 (_onProcessExit)
/vs/workbench/contrib/terminal/browser/terminalInstance.ts#975:54 (call)
/vs/base/common/event.ts#572:15 (fire)
/vs/workbench/contrib/terminal/browser/terminalProcessManager.ts#293:22 (_onExit)
/vs/workbench/contrib/terminal/browser/terminalProcessManager.ts#171:47 (call)
/vs/base/common/event.ts#572:15
at _processStartupComplete
@Tyriar Tyriar added this to the July 2019 milestone Jul 30, 2019
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues labels Jul 30, 2019
@Tyriar
Copy link
Member

Tyriar commented Jul 30, 2019

Repro: create a terminal and kill it

@Tyriar Tyriar mentioned this issue Jul 31, 2019
Closed
@Tyriar Tyriar added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Jul 31, 2019
@Tyriar Tyriar closed this as completed in a1d910f Jul 31, 2019
@rebornix rebornix added the verified Verification succeeded label Aug 1, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 14, 2019
lemanschik pushed a commit to code-oss-dev/code that referenced this issue Nov 25, 2022
@Tyriar
xterm@3.15.0-beta90
fbd8799 
Diff: xtermjs/xterm.js@689fb6b...d20068c

Changes:

- Make dispose idempotent

Fixes microsoft#78184
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Projects
None yet
Milestone
July 2019
Development

No branches or pull requests
3 participants
@rebornix @jrieken @Tyriar