Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Go to definition" on symbol with multiple definitions does not navigate to the first item, and the first item can't be opened #78521

Closed
roblourens opened this issue Aug 5, 2019 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release verified Verification succeeded
Milestone

Comments

@roblourens
Copy link
Member

Previously was #69613

@roblourens
Copy link
Member Author

roblourens commented Aug 5, 2019

This is from #78174 @alexr00 but that change seems correct, I think we should fix

const goto = !e.browserEvent || ((e.browserEvent instanceof MouseEvent) && e.browserEvent.detail === 2);
, I think it is just assuming that browserEvent will be undefined when triggered by the keyboard. We can change this for pass for any KeyboardEvent too. Also FYI @joaomoreno

@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release labels Aug 5, 2019
@roblourens roblourens added this to the July 2019 milestone Aug 5, 2019
@RMacfarlane RMacfarlane added the verified Verification succeeded label Aug 5, 2019
@jrieken
Copy link
Member

jrieken commented Aug 6, 2019

Thanks @roblourens

@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants