Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keyboard layout loader: some tests are failing with ISO keyboard #78544

Closed
bpasero opened this issue Aug 6, 2019 · 2 comments
Closed

keyboard layout loader: some tests are failing with ISO keyboard #78544

bpasero opened this issue Aug 6, 2019 · 2 comments
Assignees
Labels
debt Code quality issues unit-test-failure
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Aug 6, 2019

On my setup (german layout, ISO keyboard), these tests are failing:

2 failing

  1) keyboard layout loader load default US keyboard layout:
     AssertionError [ERR_ASSERTION]: undefined == true
      at Context.test (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/services/keybinding/test/browserKeyboardMapper.test.js:27:20)

  2) keyboard layout loader isKeyMappingActive:

      AssertionError [ERR_ASSERTION]: false == true
      + expected - actual

      -false
      +true
      
      at Context.test (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/services/keybinding/test/browserKeyboardMapper.test.js:42:20)
@bpasero bpasero added debt Code quality issues unit-test-failure labels Aug 6, 2019
@bpasero
Copy link
Member Author

bpasero commented Aug 6, 2019

Pushed bb0e9fd to disable these tests.

@rebornix
Copy link
Member

No longer test if the default chosen keyboard layout is U.S as it would fail locally when using ISO layouts.

@bpasero bpasero added this to the August 2019 milestone Aug 22, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues unit-test-failure
Projects
None yet
Development

No branches or pull requests

2 participants