Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

editor.Hover message box Position #78560

Closed
zhiqiang-hhhh opened this issue Aug 6, 2019 · 5 comments · Fixed by #127609
Closed

editor.Hover message box Position #78560

zhiqiang-hhhh opened this issue Aug 6, 2019 · 5 comments · Fixed by #127609
Assignees
@alexdima
Labels
editor-hover Editor mouse hover feature-request Request for new features or functionality

Comments

@zhiqiang-hhhh
Copy link

Issue Type: Feature Request

I want the editor.hover message could display under the variables it refers to. Because the message box blocks the code over the current line.
Thank you.

VS Code version: Code 1.36.1 (2213894, 2019-07-08T22:59:35.033Z)
OS version: Windows_NT x64 10.0.17134
@jrieken jrieken assigned alexdima and unassigned jrieken Aug 6, 2019
@alexdima alexdima added editor-hover Editor mouse hover feature-request Request for new features or functionality labels Aug 7, 2019
@alexdima alexdima added this to the Backlog milestone Aug 7, 2019
@alexdima alexdima removed their assignment Aug 7, 2019
@octref octref self-assigned this Oct 25, 2019
@Tyriar Tyriar assigned Tyriar and unassigned octref Aug 26, 2020
@Timmmm
Copy link
Contributor

Timmmm commented Jun 29, 2021 •
edited

The default is set here. Can we just change the default to BELOW or does this require a setting?

@Tyriar
Copy link
Member

Tyriar commented Jun 29, 2021

Kind of feel like this is out of scope, but I don't think this should be assigned to me since it's regarding monaco.

@Tyriar Tyriar assigned alexdima and unassigned Tyriar Jun 29, 2021
@Timmmm
Copy link
Contributor

Timmmm commented Jun 29, 2021

Actually I was wrong - it is determined by this code:

I verified if I swap the order then the hovers appear below instead of above (where there's space). I'll make a PR.

@Timmmm
Copy link
Contributor

Timmmm commented Jun 30, 2021

Done! Before:

Screenshot 2021-06-30 at 08 45 06

Change the setting:

Screenshot 2021-06-30 at 08 45 14

After:

Screenshot 2021-06-30 at 08 45 22

Timmmm added a commit to Timmmm/vscode that referenced this issue Jun 30, 2021
@Timmmm
Add setting to control hover position
ee601d1 
This adds a hover setting to control whether the user wants hovers to appear above or below the relevant line, if there's space.

Fixes microsoft#78560
@Timmmm Timmmm mentioned this issue Jun 30, 2021
Merged
@alexdima
Copy link
Member

Let's continue tracking in #30797

@alexdima alexdima modified the milestones: Backlog, October 2021 Oct 27, 2021
@alexdima alexdima added verification-needed Verification of issue is requested and removed verification-needed Verification of issue is requested labels Oct 27, 2021
@rzhao271 rzhao271 removed this from the October 2021 milestone Oct 29, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
editor-hover Editor mouse hover feature-request Request for new features or functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add setting to control hover position Timmmm/vscode
7 participants
@Timmmm @jrieken @Tyriar @octref @alexdima @rzhao271 @zhiqiang-hhhh