Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal: shift dragging causes lots of console errors #78614

Closed
joaomoreno opened this issue Aug 7, 2019 · 1 comment
Closed

Terminal: shift dragging causes lots of console errors #78614

joaomoreno opened this issue Aug 7, 2019 · 1 comment
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Milestone
August 2019

Comments

@joaomoreno
Copy link
Member

On Linux (maybe tmux only?)

  1. Open Terminal
  2. Reload workbench
  3. Shift click and drag in the terminal

This doesn't repro if I first click into the terminal and then shift click&drag.

image
@Tyriar Tyriar mentioned this issue Aug 7, 2019
Closed
@Tyriar Tyriar added this to the July 2019 milestone Aug 7, 2019
@Tyriar
Copy link
Member

Tyriar commented Aug 7, 2019 •
edited

This appears to only happen if you have not made any selection yet, plus it's not meant to do anything here anyway, so it's not that big of a deal. Fixing in August.

@Tyriar Tyriar modified the milestones: July 2019, August 2019 Aug 7, 2019
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels Aug 7, 2019
@Tyriar Tyriar closed this as completed in adb3eda Aug 7, 2019
@roblourens roblourens added the verified Verification succeeded label Aug 28, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 21, 2019
lemanschik pushed a commit to code-oss-dev/code that referenced this issue Nov 25, 2022
@Tyriar
xterm@3.15.0-beta93
65cf0ac 
Diff: xtermjs/xterm.js@d20068c...58e1b0d

Changes:

- Add mouse report tests
- Fix shift+click throwing
- Fix DECSTBM

Fixes microsoft#78614
Fixes microsoft#78355
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Projects
None yet
Milestone
August 2019
Development

No branches or pull requests
3 participants
@joaomoreno @roblourens @Tyriar