Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open Editors: moving group does not update numbers properly #78715

Closed
bpasero opened this issue Aug 8, 2019 · 0 comments
Closed

Open Editors: moving group does not update numbers properly #78715

bpasero opened this issue Aug 8, 2019 · 0 comments
Assignees
@bpasero
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workbench-editor-grid Grid layout issues in the editor area
Milestone
August 2019

Comments

@bpasero
Copy link
Member

bpasero commented Aug 8, 2019

Steps to Reproduce:

  1. open 2 editors side by side
  2. notice how open editors view shows "Group 1" and then "Group 2"
  3. move the second editor group to the left of the first one

=> 馃悰 the open editors view shows "Group 2" and then "Group 1"
=> a reload "fixes" it

It seems we are missing to update labels when reordering groups. I do not think this was intentional.

//cc @isidorn
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug workbench-editor-grid Grid layout issues in the editor area labels Aug 8, 2019
@bpasero bpasero self-assigned this Aug 8, 2019
@bpasero bpasero added this to the August 2019 milestone Aug 8, 2019
pull bot pushed a commit to Pandinosaurus/vscode that referenced this issue Aug 8, 2019
@bpasero
fix microsoft#78715
8ebfa68
@bpasero bpasero closed this as completed Aug 8, 2019
@RMacfarlane RMacfarlane added the verified Verification succeeded label Aug 28, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workbench-editor-grid Grid layout issues in the editor area
Projects
None yet
Milestone
August 2019
Development

No branches or pull requests
2 participants
@bpasero @RMacfarlane