Add "Toggle side by side view" to command palette

[garyking]

To activate "Toggle side by side view" when viewing changes, I need to click on the ellipsis in the top-right corner, then choose the option.

Instead, please add the option to the command palette, so that I can also activate it from there.

[octref]

What option are you referring to?

Do you mean "Toggle vertical/horizontal editor layout" command?

[garyking]

"Toggle side by side view"

[vscodebot]

This issue is caused by an extension, please file it with the repository (or contact) the extension has linked in its overview in VS Code or the marketplace for VS Code. See also our issue reporting guidelines.

Happy Coding!

[octref]

Please open issue against extensions. I suppose this one comes from GitLens.

[garyking]

What? Absolutely not. It's a VS Code feature.

[garyking]

Here's the source code:

vscode/src/vs/workbench/browser/parts/editor/editor.contribution.ts

Line 445 in 642d3a0

MenuRegistry.appendMenuItem(MenuId.EditorTitle, { command: { id: editorCommands.TOGGLE_DIFF_SIDE_BY_SIDE, title: nls.localize('toggleSideBySideView', "Toggle Side By Side View") }, group: '1_diff', order: 10, when: ContextKeyExpr.has('isInDiffEditor') });

It only appears when viewing Git changes to a file.

[garyking]

Can this issue be opened? Are we allowed to request for commands such as this one to appear in the command palette? Why are some actions available in the command palette, while others are not?

This option is hidden behind a dropdown menu, so it would be easier to activate it with the command palette. As you can see, I've also already added a shortcut to it, so it isn't a huge concern, but I was also curious about the questions posed above—namely, why some actions are in the command palette, while others aren't, when it seems like adding actions to the command palette wouldn't ruin the UI, considering the palette gets filtered by what the user types. And most of the other options in the same dropdown are available in the palette.

[joaomoreno]

This is already implemented:

• The command is called Toggle Inline View instead of Toggle Side by Side View
• It's also available as toggle.diff.renderSideBySide for customizing in the Keyboard Shortcuts

cc @bpasero

[garyking]

I'd just like to note the inconsistency that the option is called "Toggle Side by Side View" in the dropdown, regardless if the current state is side-by-side or inline, and the command palette option is "Compare: Toggle inline view".

[octref]

Reopening since just hitting this today:

One cannot possibly discover the "Toggle Inline View" since it's inconsistent with the ... action name.

[bpasero]

I pushed a change to name it "Toggle Inline View" consistently.