Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icons keep changing on refresh with wrong icon per file type #79469

Closed
radu-matei opened this issue Aug 19, 2019 · 4 comments
Closed

Icons keep changing on refresh with wrong icon per file type #79469

radu-matei opened this issue Aug 19, 2019 · 4 comments
Assignees
@bpasero
Labels
bug Issue identified by VS Code Team member as probable bug file-decorations verified Verification succeeded
Milestone
August 2019

Comments

@radu-matei
Copy link

radu-matei commented Aug 19, 2019 •
edited

Version: 1.38.0-insider (user setup)
Commit: c8d44e2
Date: 2019-08-19T12:53:53.607Z
Electron: 4.2.9
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
OS: Windows_NT x64 10.0.18963

Steps to Reproduce:

  1. install any file icon theme
  2. open a project, refresh the file tree

icons
@vscodebot
Copy link

vscodebot bot commented Aug 19, 2019

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@RMacfarlane RMacfarlane added the file-explorer Explorer widget issues label Aug 19, 2019
@isidorn
Copy link
Contributor

isidorn commented Aug 20, 2019

I can not reproduce this with the built-in seti icon theme?
What icon theme are you using? What theme are you using? Can you reproduce if you disable all extensions and use built-in themes?

@isidorn isidorn added the info-needed Issue requires more information from poster label Aug 20, 2019
@frankintrahouse
Copy link

frankintrahouse commented Aug 20, 2019 •
edited

I have the same issue on the latest insiders build
It seems to be confused no matter what Icon Theme you select, and if you disable the Explorer Decoration: Badges, they still show for some files.
I am using the 'Default Dark+' theme.

Here are some screenshots:
Selection_215
Selection_216
Selection_217
Selection_218

@isidorn
Copy link
Contributor

isidorn commented Aug 20, 2019 •
edited

I also see some icon funkiness with wrong indent. Forwarding to @bpasero since I believe he touched this area. Assign back to me if you are unaware of changes and I can investigate more.

wrongIndent

fyi @aeschli

@isidorn isidorn assigned bpasero and unassigned isidorn Aug 20, 2019
@isidorn isidorn added file-decorations and removed file-explorer Explorer widget issues info-needed Issue requires more information from poster labels Aug 20, 2019
@bpasero bpasero added this to the August 2019 milestone Aug 20, 2019
@bpasero bpasero closed this as completed Aug 20, 2019
bpasero added a commit that referenced this issue Aug 20, 2019
@bpasero
fix #79469
71c1fe1
@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Aug 20, 2019
@RMacfarlane RMacfarlane mentioned this issue Aug 21, 2019
Closed
This was referenced Aug 21, 2019
Closed
Closed
@RMacfarlane RMacfarlane added the verified Verification succeeded label Aug 28, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug file-decorations verified Verification succeeded
Projects
None yet
Milestone
August 2019
Development

No branches or pull requests
5 participants
@bpasero @isidorn @RMacfarlane @radu-matei @frankintrahouse