Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mac: Undo, Redo, Select All not working in native dialogs (use roles for those?) #797

Closed
kaiye opened this issue Nov 29, 2015 · 4 comments
Closed

Mac: Undo, Redo, Select All not working in native dialogs (use roles for those?) #797

kaiye opened this issue Nov 29, 2015 · 4 comments
Assignees
@bpasero
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s)
Milestone
Backlog

Comments

@kaiye
Copy link

kaiye commented Nov 29, 2015

Please check the screenshot below, it should select all the text include the file extension, however it was not working.

select-all-not-working
@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Nov 30, 2015
@bpasero bpasero modified the milestones: Dec 2015, Backlog Nov 30, 2015
@bpasero bpasero modified the milestones: April 2016, Backlog Mar 24, 2016
@bpasero bpasero changed the title 'Select All' command is not working in the file 'Save as' dailog Mac: Undo, Redo, Select All not working in native dialogs (use roles for those?) Mar 24, 2016
@bpasero bpasero assigned alexdima and unassigned bpasero Mar 24, 2016
@bpasero
Copy link
Member

bpasero commented Mar 24, 2016

This change brings back the "role" attribute to undo, redo and selectAll. From my testing this is not causing any harm because it seems to me using the keybindings within the workbench never reaches the menu. However, when you are in dev tools or in the native file dialog and invoke the keybindings, the menu to the top quickly flashes blue and indicates the action is used from there. Suggest we run with this change for a sprint and watch out for regressions.

bpasero added a commit that referenced this issue Mar 29, 2016
@bpasero
Revert "Mac: Undo, Redo, Select All not working in native dialogs (us…
29c6d72 
…e roles for those?) (fixes #797)"

This reverts commit f643462.
@bpasero bpasero mentioned this issue Mar 29, 2016
Closed
@bpasero
Copy link
Member

bpasero commented Mar 29, 2016

This was causing #4717, reverting my change.

@bpasero bpasero reopened this Mar 29, 2016
@bpasero bpasero self-assigned this Mar 29, 2016
@bpasero bpasero modified the milestones: Backlog, April 2016 Mar 29, 2016
@bpasero bpasero added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Mar 29, 2016
@bpasero
Copy link
Member

bpasero commented Mar 29, 2016

Marking as upstream. Imho this should work without special code from our end, or if any we have API to find out if a native dialog is opened or not.

@bpasero bpasero mentioned this issue Aug 16, 2016
Closed
@bpasero bpasero removed the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Aug 31, 2016
@bpasero
Copy link
Member

bpasero commented Aug 31, 2016

#8439

@bpasero bpasero closed this as completed Aug 31, 2016
@bpasero bpasero added the *duplicate Issue identified as a duplicate of another issue(s) label Aug 31, 2016
@brandonbloom brandonbloom mentioned this issue Sep 6, 2017
Closed
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@kaiye @bpasero @alexdima