Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS Code setting scss.lint.unknownAtRule isn't recognized but applies css.lint.unknownAtRule logic #79768

Closed
andrecasal opened this issue Aug 25, 2019 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug css-less-scss Issues and items concerning CSS,Less,SCSS styling verified Verification succeeded
Milestone

Comments

@andrecasal
Copy link

VS Code setting scss.lint.unknownAtRule isn't recognized nor part of the defaultSettings.json but applies css.lint.unknownAtRule logic.

VSCode Version: 1.37.1
Commit: f06011a
Date: 2019-08-15T16:16:34.800Z
Electron: 4.2.7
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
OS: Darwin x64 18.7.0

Video explaining the issue: https://youtu.be/7ubqkAU7QkE

Steps to Reproduce:

  1. Copy "scss.lint.unknownAtRules": "warning" to your setting.json file
  2. Write a valid @rule in SCSS like @at-rule.
  3. VS Code doesn't recognize this SCSS @at-rule, but seems to recognize all other CSS @rules.

Wouldn't it make sense to have an scss.lint.unknownAtRules in the settings.json file or am I missing something?

Does this issue occur when all extensions are disabled?: Yes

@RMacfarlane RMacfarlane added the css-less-scss Issues and items concerning CSS,Less,SCSS styling label Aug 26, 2019
@octref octref added the bug Issue identified by VS Code Team member as probable bug label Aug 26, 2019
@octref octref added this to the September 2019 milestone Aug 26, 2019
@octref octref modified the milestones: September 2019, October 2019 Sep 30, 2019
@octref octref closed this as completed in 603d861 Oct 22, 2019
@octref
Copy link
Contributor

octref commented Oct 22, 2019

Added one for scss and one for less.

@connor4312 connor4312 added the verified Verification succeeded label Oct 30, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug css-less-scss Issues and items concerning CSS,Less,SCSS styling verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants