Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inline diff actions should use singular when a single line is deleted #79877

Closed
egamma opened this issue Aug 27, 2019 · 3 comments
Closed

Inline diff actions should use singular when a single line is deleted #79877

egamma opened this issue Aug 27, 2019 · 3 comments
Assignees
@rebornix
Milestone
August 2019

Comments

@egamma
Copy link
Member

egamma commented Aug 27, 2019

Testing #79833

When a single line is deleted:

image

Then the label should be 'Copy deleted line content to the clipboard'
@egamma egamma changed the title Inline diff quick fix actions should be singular when a single line is deleted Inline diff actions should use singular when a single line is deleted Aug 27, 2019
@chrisdias
Copy link
Member

I think the word "content" is not necessary...

"Copy deleted line (xx) to the clipboard"
"Copy deleted lines to the clipboard"

@egamma
Copy link
Member Author

egamma commented Aug 28, 2019

see also #79879

rebornix added a commit that referenced this issue Aug 28, 2019
@rebornix
Re #79877. Improve wording for inline diff actions.
7449c80
@rebornix
Copy link
Member

Fixed via 7449c80 . Took suggestion from #79879 (comment) . Thanks for all the suggestions.

@rebornix rebornix mentioned this issue Aug 28, 2019
Closed
@rebornix rebornix added this to the August 2019 milestone Aug 28, 2019
@anthonydresser anthonydresser mentioned this issue Sep 13, 2019
Merged
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rebornix rebornix

Labels
None yet
Projects
None yet
Milestone
August 2019
Development

No branches or pull requests
3 participants
@egamma @rebornix @chrisdias