Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron 6: debugging extension quits immediately #79929

Closed
rebornix opened this issue Aug 27, 2019 · 7 comments
Closed

Electron 6: debugging extension quits immediately #79929

rebornix opened this issue Aug 27, 2019 · 7 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug electron-blocker Issues in next update of Electron preventing update upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Milestone

Comments

@rebornix
Copy link
Member

Testing #79731

No error at all in Debug Console.

@deepak1556
Copy link
Contributor

Renderer log shows

[2019-08-27 12:56:01.181] [renderer1] [error] Cannot connect to runtime process, timeout after 10000 ms - (reason: Cannot connect to the target: connect ECONNREFUSED 127.0.0.1:18925).: Error: Cannot connect to runtime process, timeout after 10000 ms - (reason: Cannot connect to the target: connect ECONNREFUSED 127.0.0.1:18925).
    at handleErrorResponse (file:///Users/demohan/Downloads/Visual Studio Code - Exploration.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:2658:583)
    at file:///Users/demohan/Downloads/Visual Studio Code - Exploration.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:2658:37
    at processTicksAndRejections (internal/process/task_queues.js:89:5)
[2019-08-27 12:56:20.039] [renderer1] [error] Cannot connect to runtime process, timeout after 10000 ms - (reason: Cannot connect to the target: connect ECONNREFUSED 127.0.0.1:45392).: Error: Cannot connect to runtime process, timeout after 10000 ms - (reason: Cannot connect to the target: connect ECONNREFUSED 127.0.0.1:45392).
    at handleErrorResponse (file:///Users/demohan/Downloads/Visual Studio Code - Exploration.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:2658:583)
    at file:///Users/demohan/Downloads/Visual Studio Code - Exploration.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:2658:37
    at processTicksAndRejections (internal/process/task_queues.js:89:5)

@deepak1556 deepak1556 added bug Issue identified by VS Code Team member as probable bug electron-6.0.x-update labels Aug 27, 2019
@bpasero
Copy link
Member

bpasero commented Aug 28, 2019

Adding @weinand @isidorn to investigate too.

@bpasero bpasero assigned deepak1556, weinand and isidorn and unassigned deepak1556 Aug 28, 2019
@bpasero bpasero added the electron-blocker Issues in next update of Electron preventing update label Aug 28, 2019
@deepak1556
Copy link
Contributor

Just to update this happens on all platforms, I tested on windows, macOS and linux.

@bpasero bpasero added this to the September 2019 milestone Aug 29, 2019
@weinand
Copy link
Contributor

weinand commented Sep 2, 2019

When Electron is run as node (via the ELECTRON_RUN_AS_NODE flag), it immediately crashes when passing the --inspect-brk flag:
2019-09-02_16-12-36

Passing a --inspect flag instead works fine.

Since Electron is crashing deep down in C++ code (instead of showing a message that --inspect-brk is not supported), I consider this a severe Electron 6.0 bug (and I don't plan to work around this issue in VS Code).

I've added the "upstream" label.

@weinand weinand added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Sep 2, 2019
@weinand weinand removed their assignment Sep 2, 2019
@bpasero
Copy link
Member

bpasero commented Sep 2, 2019

I wonder if this is a regression from electron/electron#19316 or similar.

@deepak1556
Copy link
Contributor

Fix at electron/electron#20098 , should be available with next release.

@bpasero bpasero closed this as completed Sep 14, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 29, 2019
@weinand weinand added the verified Verification succeeded label Oct 30, 2019
@weinand
Copy link
Contributor

weinand commented Oct 30, 2019

Extension debugging works fine with Electron 6.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug electron-blocker Issues in next update of Electron preventing update upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants