Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to cursorSurroundingLines to ignore clicks #79935

Closed
miguelsolorio opened this issue Aug 27, 2019 · 4 comments
Closed

Add option to cursorSurroundingLines to ignore clicks #79935

miguelsolorio opened this issue Aug 27, 2019 · 4 comments
Assignees
Labels
editor-rendering Editor rendering issues feature-request Request for new features or functionality verified Verification succeeded
Milestone

Comments

@miguelsolorio
Copy link
Contributor

Testing #79834

It would be great if there was an option in editor.cursorSurroundingLines to ignore clicks and only act on scrolling via the keyboard. I like this feature but don't want this to apply to mouse clicks.

@rebornix
Copy link
Member

This request is valid and might be annoying to heavy-mouse users. Currently there are three major sources for selection reveal

  • mouse
  • keyboard
  • api (either from the core commands, or extensions like Vim)

For this particular case, we may only need one boolean setting to disable this feature just for mouse but probably there are users who only want this feature to kick in when using keyboard but not from api and mouse, if so then we need an array or a setting which is richer.

Let's see the feedback and then decide.

@rebornix rebornix added this to the On Deck milestone Aug 28, 2019
@alexdima alexdima removed the editor-code-actions Editor inplace actions (Ctrl + .) label Oct 17, 2019
@myfonj
Copy link

myfonj commented Oct 23, 2019

#79934 was fixed for simple click, but the same issue prevails for case user intends to select text in area affected by editor.cursorSurroundingLines using mouse: as soon as single letter becomes selected, this selection is pushed out of the border area, text rolls under pressed mouse cursor what continues to select more etc.. what is hardly ever the intended behavior for strictly horizontal mouse selection that does not leave editor area:

surroundUnIntededSelection

I guess it was overlooked in #79934, but if there was proposed option to exclude mouse actions from cursorSurroundingLines interventions it would be viable workaround.

@rebornix
Copy link
Member

thanks, I agree that having ways to opt out for mouse has great value.

@rebornix rebornix added the editor-rendering Editor rendering issues label Oct 24, 2019
@rebornix rebornix modified the milestones: On Deck, October 2019 Oct 24, 2019
@rebornix
Copy link
Member

rebornix commented Oct 24, 2019

By default it won't do any scroll off when triggered from mouse rom tomorrow's Insiders.

@rebornix rebornix added the verification-needed Verification of issue is requested label Oct 29, 2019
@miguelsolorio miguelsolorio added verified Verification succeeded and removed verification-needed Verification of issue is requested labels Oct 29, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
editor-rendering Editor rendering issues feature-request Request for new features or functionality verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants