Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UTF-8 'ñÑ' cannot be written in the vscode terminal #80072

Closed
maravento opened this issue Aug 29, 2019 · 17 comments · Fixed by #80830
Closed

UTF-8 'ñÑ' cannot be written in the vscode terminal #80072

maravento opened this issue Aug 29, 2019 · 17 comments · Fixed by #80830
Assignees
Labels
feature-request Request for new features or functionality terminal Integrated terminal issues verification-needed Verification of issue is requested verified Verification succeeded

Comments

@maravento
Copy link

maravento commented Aug 29, 2019

I write in the terminal 'manana', but I can't write 'mañana', it doesn't allow it. If I try to insert the letter 'ñ' in the word 'manana' it is not allowed either.
manana
manana
mañana
mañana

@vscodebot
Copy link

vscodebot bot commented Aug 29, 2019

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@maravento
Copy link
Author

It is not in a text. it's in the terminal

@Tyriar
Copy link
Member

Tyriar commented Sep 6, 2019

What platform? If you're on Windows what shell is that?

@Tyriar Tyriar added info-needed Issue requires more information from poster terminal Integrated terminal issues labels Sep 6, 2019
@maravento
Copy link
Author

ubuntu 18.04.3 x64

@Tyriar
Copy link
Member

Tyriar commented Sep 6, 2019

I can't reproduce, it's likely an environment config issue. I recommend looking into the setLocaleVariables setting and your $LANG env var

@Tyriar Tyriar added the *not-reproducible Issue cannot be reproduced by VS Code Team member as described label Sep 6, 2019
@vscodebot
Copy link

vscodebot bot commented Sep 6, 2019

We closed this issue because we are unable to reproduce the problem with the steps you describe. Chances are we've already fixed your problem in a recent version of VS Code. If not, please ask us to reopen the issue and provide us with more detail. Our issue reporting guidelines might help you with that.

Happy Coding!

@vscodebot vscodebot bot closed this as completed Sep 6, 2019
@maravento
Copy link
Author

maravento commented Sep 6, 2019

i found workaround here #35550 (comment)

@Tyriar
Copy link
Member

Tyriar commented Sep 7, 2019

@maravento can you share the good $LANG value (with setLocaleVariables: false) and the bad one (where it's not set)?

@maravento
Copy link
Author

maravento commented Sep 7, 2019

local: echo $LANG
es_CO.UTF-8

@Tyriar
Copy link
Member

Tyriar commented Sep 9, 2019

@maravento is that the one that's working? If so what's the value when it's not working?

@maravento
Copy link
Author

maravento commented Sep 9, 2019

In Ubuntu 18.04.x x 64 LTS, with locales es_CO.UTF-8:

When check the box terminal.integrated.setLocaleVariables And I press 'ñ' on the terminal, the out is '(arg: 1)' (close and open first)
Captura de pantalla -2019-09-09 14-33-04
When uncheck the box terminal.integrated.setLocaleVariables And I press 'ñ or Ñ' on the terminal, the out is 'ñÑ' (close and open first)
2

@Tyriar
Copy link
Member

Tyriar commented Sep 12, 2019

It's probably setting the $LANG to "es_ES.UTF-8" when setLocaleVariables is true which doesn't seem to want to let you type. We should probably make the default for setLocaleVariables "auto" and only set it if $LANG does not end in ".UTF-8".

/cc @jerch

@Tyriar Tyriar reopened this Sep 12, 2019
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug and removed *not-reproducible Issue cannot be reproduced by VS Code Team member as described info-needed Issue requires more information from poster labels Sep 12, 2019
@Tyriar Tyriar added this to the September 2019 milestone Sep 12, 2019
@maravento
Copy link
Author

maravento commented Sep 12, 2019

The same happens: in 'Workspace' and in 'User' too (only tested in Ubuntu 18.04.3 x64 es_CO.UTF-8)
Captura de pantalla -2019-09-12 18-00-55
Captura de pantalla -2019-09-12 18-01-23

Tyriar added a commit that referenced this issue Sep 12, 2019
Tyriar added a commit that referenced this issue Sep 12, 2019
Tyriar added a commit that referenced this issue Sep 12, 2019
The setting is now an enum instead of boolean and defaults to auto
which should provide better detection and not set in cases where it
shouldn't.

Fixes #80072
@maravento maravento changed the title the letter 'ñ' cannot be written in the vscode terminal UTF-8 'ñÑ' cannot be written in the vscode terminal Sep 13, 2019
@Tyriar Tyriar removed the bug Issue identified by VS Code Team member as probable bug label Sep 16, 2019
@Tyriar Tyriar added the feature-request Request for new features or functionality label Sep 16, 2019
@Tyriar
Copy link
Member

Tyriar commented Sep 30, 2019

Verify that terminal.integrated.detectLocale works on Linux or macOS as described in its setting description. echo $LANG in the terminal to verify the values, its eventual value depends on:

  • The value of the setting
  • What $LANG is set in Code's enironment
  • The display language of VS Code (change using Configure Display Language command)

@maravento
Copy link
Author

Why do you close the ticket if the problem is still there, without solution?

@Tyriar
Copy link
Member

Tyriar commented Oct 1, 2019

@maravento because you have a workaround in #80072 (comment) and the fix is to not do this in your case which will be included in the next release.

@maravento
Copy link
Author

@Tyriar Ok. Thanks

@roblourens roblourens added the verified Verification succeeded label Oct 3, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality terminal Integrated terminal issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants