Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link Protection Improvements #80595

Closed
5 tasks done
octref opened this issue Sep 9, 2019 · 7 comments · Fixed by #80951
Closed
5 tasks done

Link Protection Improvements #80595

octref opened this issue Sep 9, 2019 · 7 comments · Fixed by #80951
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workbench-link Link protection in workbench

Comments

@octref
Copy link
Contributor

octref commented Sep 9, 2019

@octref octref self-assigned this Sep 9, 2019
@octref octref added the bug Issue identified by VS Code Team member as probable bug label Sep 9, 2019
@octref octref added this to the September 2019 milestone Sep 9, 2019
octref added a commit that referenced this issue Sep 11, 2019
octref added a commit that referenced this issue Sep 13, 2019
octref added a commit that referenced this issue Sep 15, 2019
@octref
Copy link
Contributor Author

octref commented Sep 15, 2019

The new dialog is more clearer:

image

And the configuration process becomes editing a JSON file (for the 3rd option above):

image

These two commands will be available:

image

@octref
Copy link
Contributor Author

octref commented Sep 15, 2019

@jrieken In Redmond we discussed how we can improve the link protection configuring experience, but we realize QuickInput is not the right widget for all CRUD operations. So I went with the approach of having a FS provider and let use configure the JSON setting.

I see #10547 and @Tyriar is interested in having something similar for editing an in-memory item in terminal area. I'm wondering if we should have a dedicated schema for such use cases.

@aeschli
Copy link
Contributor

aeschli commented Oct 2, 2019

@octref Why is the list of trusted domains done is a separate (virtual) resource and not part of the (user) settings?
That way it will be profit from our synced-settings story.

@aeschli
Copy link
Contributor

aeschli commented Oct 2, 2019

Can you describe what is there to verify (I have the feeling this would even deserve it's own test item...)

@Tyriar
Copy link
Member

Tyriar commented Oct 2, 2019

@aeschli because an extension could just write the settings and bypass the security feature completely.

@microsoft microsoft deleted a comment from octref Oct 3, 2019
@microsoft microsoft deleted a comment from aeschli Oct 3, 2019
@samrat-gavale
Copy link

@octref how is this to be handled in an enterprise scenario? e.g. like when an engineering services team wants to create a one-click setup for a development environment, which consists of a couple of extensions pointing users to a bunch of external sites? Currently there is no way but to ask each developer to configure those domains.

@octref
Copy link
Contributor Author

octref commented Oct 17, 2019

@samrat-gavale I opened #82794 but I don't have a plan yet. If you have a good suggestion how this might work, please follow up in that thread.

@octref octref added the workbench-link Link protection in workbench label Oct 29, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workbench-link Link protection in workbench
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants