Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doesn't highlight comment in C++ member initializer lists #80644

Closed
hokein opened this issue Sep 10, 2019 · 4 comments
Closed

doesn't highlight comment in C++ member initializer lists #80644

hokein opened this issue Sep 10, 2019 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug grammar Syntax highlighting grammar upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded

Comments

@hokein
Copy link

hokein commented Sep 10, 2019

  • VSCode Version: 1.37.0
  • OS Version: Linux

Steps to Reproduce:

Open test.cpp:

struct Foo {
  Foo();
  int a;
  int b;
  int c;
};
Foo::Foo()
    : a(1),
      //     b(2),
      c(3) {}

See screenshot:

image

comment on line 12 is not highlighted.

Does this issue occur when all extensions are disabled?: Yes

@vscodebot
Copy link

vscodebot bot commented Sep 10, 2019

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@alexr00
Copy link
Member

alexr00 commented Sep 11, 2019

Thanks @matter123 for coping this over to jeff-hykin/better-cpp-syntax#389

Leaving open to verify after the grammar changes is pulled in.

@alexr00 alexr00 added bug Issue identified by VS Code Team member as probable bug grammar Syntax highlighting grammar upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels Sep 11, 2019
@alexr00 alexr00 added this to the September 2019 milestone Sep 11, 2019
@jeff-hykin
Copy link

Fix pushed for the latest version 1.14.6
I went to the stable branch, version 1.8.15 but I can't reproduce the issue on there so I'm not sure what version is in VS Code 1.37.0.

@alexr00
Copy link
Member

alexr00 commented Sep 16, 2019

Grammar update to 1.14.6 and test added for this case!

@mjbvz mjbvz added the verified Verification succeeded label Oct 3, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug grammar Syntax highlighting grammar upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants