Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please allow overriding theme icon colors #81216

Closed
anatolyburakov opened this issue Sep 20, 2019 · 2 comments
Closed

Please allow overriding theme icon colors #81216

anatolyburakov opened this issue Sep 20, 2019 · 2 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@anatolyburakov
Copy link

This the original issue: microsoft/vscode-docs#3086

As it stands now, it is impossible to create light theme with dark tab bar. While i understand that allowing to theme every single element is too much work, an easier option would've been to allow overriding "dark" vs "light" type for every icon (e.g. menu key shortcuts, palette key shortcuts, tab bar icons, etc.).

This would allow creation of themes that are reminiscent of Qt Creator interface (light theme), which is nicely balanced and clearly delineates active areas without being all white and in your face like VSCode is.

@vscodebot
Copy link

vscodebot bot commented Sep 20, 2019

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@miguelsolorio
Copy link
Contributor

I'm going to say this is covered by #78889 which introduces icon fonts and color themes for icons.

@miguelsolorio miguelsolorio added the *duplicate Issue identified as a duplicate of another issue(s) label Sep 24, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

2 participants