-
Notifications
You must be signed in to change notification settings - Fork 29.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use icon fonts for product icons #78889
Comments
Please use a modern approach with SVG icons, not hacky fonts. With SVG you can customise everything, size, color, gradients fill, animations, fill opacity. You can even use SVG icons as mask for opacity shades (using black-to-transparent gradient, see example). SVG technology is the today way to handle icons while fonts are an hacky approach made almost 7 years ago. Fonts are hard to maintain, require a lot of CSS code (for example a class for each icon) and they are really huge in terms of KB's. |
@equinusocio thanks for the suggestions, but we already use icon fonts with file icons and Octicons. |
Yes i know, but every font icon is generated from single svg files. What i'm suggesting is to improve loading/rendering performance and maintainability by using the SVG files directly and move away from icon fonts. So you still use your file icons and octicons but as SVG. With this improvement theme authors can also provide their icons to customize the workbench :) |
There is a great post from GitHub on why dropping icon fonts is a good idea: https://github.blog/2016-02-22-delivering-octicons-with-svg/ |
Please add the ability to have custom icons in the sidebar and status bar. |
Summary
This is to track updating our icons to use our new icon font (
codicons
) in the workbench. This will allow us to:This would allows to do something like below where icons inherit the foreground color of their element:
Notice how the icons in the selected element are different a color than the rest state
Related Issues
Out of scope
Adoption areas
Verify it works in
The text was updated successfully, but these errors were encountered: