Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider adding documentation to describe that setting message to empty string removes it from TreeView #81758

Closed
stevencl opened this issue Oct 1, 2019 · 1 comment
Closed

Consider adding documentation to describe that setting message to empty string removes it from TreeView #81758

stevencl opened this issue Oct 1, 2019 · 1 comment
Assignees
@alexr00
Labels
polish Cleanup and polish issue tree-views Extension tree view issues
Milestone
September 2019

Comments

@stevencl
Copy link
Member

stevencl commented Oct 1, 2019

Issue Type: Feature Request

Testing #81634

Everything worked well. The only suggestion I would make is to add to the documentation somewhere that setting message to the empty string removes it from the TreeView. I wasn't sure if that would just leave an empty line at the top of the TreeView but since there wasn't anything like treeView.RemoveMessage I just tried it.

VS Code version: Code - Insiders 1.39.0-insider (313ede6, 2019-10-01T07:29:05.652Z)
OS version: Windows_NT x64 10.0.18362
@alexr00 alexr00 added tree-views Extension tree view issues polish Cleanup and polish issue labels Oct 1, 2019
@alexr00 alexr00 added this to the September 2019 milestone Oct 1, 2019
@gregvanl
Copy link

gregvanl commented Oct 1, 2019

Setting to null also clears the message.

alexr00 added a commit that referenced this issue Oct 2, 2019
@alexr00
Add to jsdoc for TreeView message
f52667b 
Add info about how to remove the message

Fiexes #81758
@alexr00 alexr00 closed this as completed Oct 2, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexr00 alexr00

Labels
polish Cleanup and polish issue tree-views Extension tree view issues
Projects
None yet
Milestone
September 2019
Development

No branches or pull requests
3 participants
@stevencl @gregvanl @alexr00