Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add icons for built-in extensions #81760

Closed
miguelsolorio opened this issue Oct 1, 2019 · 6 comments
Closed

Add icons for built-in extensions #81760

miguelsolorio opened this issue Oct 1, 2019 · 6 comments
Assignees
@miguelsolorio
Labels
debt Code quality issues extensions Issues concerning extensions icons-product Issues for in-product icons insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue verification-found Issue verification failed verification-needed Verification of issue is requested verified Verification succeeded
Milestone
April 2021

Comments

@miguelsolorio
Copy link
Contributor

There is a few more built in extensions without icon:

image

image

Originally posted by @bpasero in #80677 (comment)
@miguelsolorio miguelsolorio self-assigned this Oct 1, 2019
@miguelsolorio miguelsolorio added extensions Issues concerning extensions icons-product Issues for in-product icons labels Oct 1, 2019
@miguelsolorio miguelsolorio mentioned this issue Oct 1, 2019
Closed
@miguelsolorio miguelsolorio added this to the Backlog milestone Dec 5, 2019
@miguelsolorio miguelsolorio mentioned this issue Nov 5, 2020
Closed
@miguelsolorio miguelsolorio added polish Cleanup and polish issue debt Code quality issues labels Nov 5, 2020
@miguelsolorio
Copy link
Contributor Author

Added icons for all of our built-in extensions:

CleanShot 2021-04-20 at 11 53 09

Will make PRs for the extensions that are bundled

@miguelsolorio miguelsolorio modified the milestones: Backlog, April 2021 Apr 20, 2021
@miguelsolorio miguelsolorio added the verification-needed Verification of issue is requested label Apr 20, 2021
This was referenced Apr 20, 2021
Merged
Merged
Merged
Merged
miguelsolorio pushed a commit that referenced this issue Apr 21, 2021
Update debug-auto-attach ext icon (refs #81760)
23a2409
@bpasero
Copy link
Member

bpasero commented Apr 27, 2021

image

image

These 2 still don't have icons.

@miguelsolorio
Copy link
Contributor Author

Both of those have already had the PRs merged and @connor4312 just needs to release an update:

  1. JavaScript Debugger Companion Extension - Update logos vscode-js-debug-companion#13
  2. vscode-js-profile-table - Update icons vscode-js-profile-visualizer#34

@connor4312
Copy link
Member

I will do this as part of endgame (most likely today)

@rzhao271
Copy link
Contributor

Reopening this issue for now since we still have #81760 (comment)

@rzhao271 rzhao271 reopened this Apr 29, 2021
@rzhao271 rzhao271 added the verification-found Issue verification failed label Apr 29, 2021
@miguelsolorio
Copy link
Contributor Author

@connor4312 can you close this issue once you've published those extensions? Thanks.

@bpasero bpasero added the verified Verification succeeded label Apr 30, 2021
@miguelsolorio miguelsolorio mentioned this issue May 18, 2021
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Jun 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@miguelsolorio miguelsolorio

Labels
debt Code quality issues extensions Issues concerning extensions icons-product Issues for in-product icons insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue verification-found Issue verification failed verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
April 2021
Development

No branches or pull requests
5 participants
@bpasero @connor4312 @rzhao271 @miguelsolorio and others