Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync data tree show twisty when having no children #82208

Closed
jrieken opened this issue Oct 10, 2019 · 0 comments 路 Fixed by #83760
Closed

Sync data tree show twisty when having no children #82208

jrieken opened this issue Oct 10, 2019 · 0 comments 路 Fixed by #83760
Assignees
@joaomoreno
Labels
bug Issue identified by VS Code Team member as probable bug tree-widget Tree widget issues verified Verification succeeded
Milestone
October 2019

Comments

@jrieken
Copy link
Member

jrieken commented Oct 10, 2019

  • have a sync data tree
  • don't implement hasChildren
  • filter all children of a node
  • 馃悰 the node has twisty
@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug tree-widget Tree widget issues labels Oct 10, 2019
@joaomoreno joaomoreno added this to the October 2019 milestone Oct 10, 2019
joaomoreno added a commit that referenced this issue Oct 31, 2019
@joaomoreno
fixes #82208
19baafa
@joaomoreno joaomoreno mentioned this issue Oct 31, 2019
Merged
joaomoreno added a commit that referenced this issue Oct 31, 2019
@joaomoreno
Merge pull request #83760 from microsoft/joao/fix-82208
509ed6d 
Fixes #82208
@jrieken jrieken added the verified Verification succeeded label Nov 1, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
bug Issue identified by VS Code Team member as probable bug tree-widget Tree widget issues verified Verification succeeded
Projects
None yet
Milestone
October 2019
Development

Successfully merging a pull request may close this issue.

Fixes #82208 microsoft/vscode
2 participants
@joaomoreno @jrieken