Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can not open editor of any file. #82218

Closed
gzx-miller opened this issue Oct 10, 2019 · 11 comments
Closed

can not open editor of any file. #82218

gzx-miller opened this issue Oct 10, 2019 · 11 comments
Assignees
Labels
freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues important Issue identified as high-priority info-needed Issue requires more information from poster workbench-editor-grid Grid layout issues in the editor area

Comments

@gzx-miller
Copy link

Issue Type: Bug

bootstrap-window.js:215 TypeError: Cannot read property 'layout' of undefined
at I.layout (textEditor.ts:223)
at g.layout (editorControl.ts:233)
at e.layout (editorGroupView.ts:1491)
at f.layout (gridview.ts:631)
at f.layout (splitview.ts:130)
at t.SplitView.layoutViews (splitview.ts:855)
at t.SplitView.layout (splitview.ts:423)
at m.layout (gridview.ts:284)
at v.layout (gridview.ts:774)
at p.layout (grid.ts:249)
at p.layout (grid.ts:596)
at k.layout (editorPart.ts:73)
at t.CenteredViewLayout.layout (centeredViewLayout.ts:84)
at e.doLayout (editorPart.ts:977)
at e.layout (editorPart.ts:970)
at f.layout (gridview.ts:631)
at f.layout (splitview.ts:130)
at t.SplitView.layoutViews (splitview.ts:855)
at t.SplitView.layout (splitview.ts:423)
at m.layout (gridview.ts:284)
at v.layout (splitview.ts:130)
at t.SplitView.layoutViews (splitview.ts:855)
at t.SplitView.layout (splitview.ts:423)
at m.layout (gridview.ts:284)
at f.layout (splitview.ts:130)
at t.SplitView.layoutViews (splitview.ts:855)
at t.SplitView.layout (splitview.ts:423)
at m.layout (gridview.ts:284)
at v.layout (gridview.ts:774)
at p.layout (grid.ts:249)
at p.layout (grid.ts:596)
at t.Workbench.layout (layout.ts:826)
at Q.onWindowResize (desktop.main.ts:166)
at _register.c.addDisposableListener.t (desktop.main.ts:145)

VS Code version: Code 1.39.0 (9df03c6, 2019-10-09T06:58:04.439Z)
OS version: Windows_NT x64 10.0.18362

System Info
Item Value
CPUs Intel(R) Core(TM) i5-4590 CPU @ 3.30GHz (4 x 3292)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
oop_rasterization: disabled_off
protected_video_decode: unavailable_off
rasterization: enabled
skia_deferred_display_list: disabled_off
skia_renderer: disabled_off
surface_synchronization: enabled_on
video_decode: enabled
viz_display_compositor: disabled_off
webgl: enabled
webgl2: enabled
Load (avg) undefined
Memory (System) 15.91GB (10.17GB free)
Process Argv
Screen Reader no
VM 0%
Extensions (10)
Extension Author (truncated) Version
Bookmarks ale 10.5.0
vscode-apollo apo 1.11.0
vscode-eslint dba 1.9.1
auto-close-tag for 0.5.6
python ms- 2019.10.41019
csharp ms- 1.21.4
vscode-react-native msj 0.12.1
react-node-desktop-debugger rea 2.0.0
vscode-multiclip sle 0.1.5
json Zai 1.0.2
@bpasero bpasero added important Issue identified as high-priority freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues workbench-editor-grid Grid layout issues in the editor area labels Oct 10, 2019
@bpasero bpasero assigned isidorn and unassigned bpasero Oct 10, 2019
@isidorn
Copy link
Contributor

isidorn commented Oct 10, 2019

Looking at the callStack it seems like the textEditor.layout is being called before the TextEditor is created.
Centered editor layout is enabled in this case, however it seems to be just a middle man here.

@gzx-miller
Copy link
Author

Hello, @isidorn , when I can get the fixed version?

@isidorn
Copy link
Contributor

isidorn commented Oct 10, 2019

We are still looking into a fix.
If you F1 > toggle centered layout do you still see this
Until we push a fix I suggest you use vscode insiders if you work is being blocked (sorry about that!)
https://code.visualstudio.com/insiders/

@isidorn isidorn added the candidate Issue identified as probable candidate for fixing in the next release label Oct 10, 2019
@isidorn
Copy link
Contributor

isidorn commented Oct 10, 2019

@gzx-miller can you please include a screenshot of vscode when the error happens?

@bpasero bpasero added this to the September 2019 Recovery milestone Oct 10, 2019
@sbatten
Copy link
Member

sbatten commented Oct 10, 2019

is this 100% repro? @gzx-miller can you reproduce this issue in different workspaces?

The stack suggests the error is on window resize so I've tried the following variables:

  1. Using and not using centered layout
  2. Resizing the window and quickly opening and closing files
  3. Adding editor groups to centered layout (which removes the centered layout as expected)
  4. Reloading the window in various combinations

I was not able to repro yet.

@microsoft microsoft deleted a comment from mayeths Oct 10, 2019
@microsoft microsoft deleted a comment from mayeths Oct 10, 2019
@microsoft microsoft deleted a comment from bpasero Oct 10, 2019
@microsoft microsoft deleted a comment from bpasero Oct 10, 2019
@gzx-miller
Copy link
Author

Snipaste_2019-10-11_09-38-41

@gzx-miller
Copy link
Author

gzx-miller commented Oct 11, 2019

It's 100% repro in any project, and I tried reinstall the latest version, and reboot win10 system, the problem didn't disappear. @sbatten
now, I'm using vscode inside well, thank you. @isidorn , but the inside version cann't open multiple editor.

@isidorn
Copy link
Contributor

isidorn commented Oct 11, 2019

@gzx-miller please answer all questions posted by @sbatten here thanks!

Insiders can open multiple editors, what do you mean? Can you open another issue regarding this. Please note that insiders does not have all your extensions installed.

@gzx-miller
Copy link
Author

sbatten ask:
is this 100% repro? can you reproduce this issue in different workspaces?
my answer:
It's 100% repro in any project.
insider version can not open multiple editors. I won't open another issue, because I find another way to recover my environment: install an old version of vscode, and config forbid upgrade. @isidorn

@joaomoreno
Copy link
Member

@gzx-miller Can you share a screenshot of Insiders as well?

Can you try running in a separate user data dir: code --user-data-dir NEW_FOLDER? Does it work then?

@alexdima alexdima added info-needed Issue requires more information from poster and removed candidate Issue identified as probable candidate for fixing in the next release labels Oct 11, 2019
@alexdima alexdima removed this from the September 2019 Recovery 2 milestone Oct 11, 2019
@vscodebot vscodebot bot closed this as completed Oct 18, 2019
@vscodebot
Copy link

vscodebot bot commented Oct 18, 2019

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues important Issue identified as high-priority info-needed Issue requires more information from poster workbench-editor-grid Grid layout issues in the editor area
Projects
None yet
Development

No branches or pull requests

6 participants