Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extension update and platform update are inconsistent when no updates available #82677

Closed
patrys opened this issue Oct 16, 2019 · 2 comments
Closed

Extension update and platform update are inconsistent when no updates available #82677

patrys opened this issue Oct 16, 2019 · 2 comments
Assignees
@sandy081
Labels
bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions ux User experience issues verified Verification succeeded
Milestone
November 2019

Comments

@patrys
Copy link

patrys commented Oct 16, 2019

  • VSCode Version: 1.40.0-insider
  • OS Version: macOS Mojave

Steps to Reproduce:

  1. In the Extensions pane run the "Check for Extension Updates" command
  2. From the gear icon choose "Check for Updates..."

One uses a notification while the other displays a modal:

Zrzut ekranu 2019-10-16 o 11 52 36

Zrzut ekranu 2019-10-16 o 11 53 07

Does this issue occur when all extensions are disabled?: Yes
@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug ux User experience issues labels Oct 17, 2019
@joaomoreno joaomoreno added this to the October 2019 milestone Oct 17, 2019
@isidorn
Copy link
Contributor

isidorn commented Oct 21, 2019

They should both be modal dialogs since they are user initiatied IMHO.
They should not be notifications.

Especailly since me as a User am now surprised by not getting feedback when cehcking for udpates (the notification is on the bottom right corner of my screen which I easily miss)

@joaomoreno
Copy link
Member

joaomoreno commented Oct 21, 2019 •
edited

I hate going back and forward on stuff like this, but I do agree with @isidorn. Reverting and moving forward to @sandy081.

@sandy081 Can you make the extension one modal, when the user explicitly asks for updates?

@joaomoreno joaomoreno assigned sandy081 and unassigned joaomoreno Oct 21, 2019
joaomoreno added a commit that referenced this issue Oct 21, 2019
@joaomoreno
Revert "fixes #82677"
6f2a65e 
This reverts commit 97b2c92.
@joaomoreno joaomoreno reopened this Oct 21, 2019
jrieken pushed a commit that referenced this issue Oct 21, 2019
@joaomoreno @jrieken
Revert "fixes #82677"
8d53129 
This reverts commit 97b2c92.
@joaomoreno joaomoreno removed this from the October 2019 milestone Oct 31, 2019
@joaomoreno joaomoreno added the extensions Issues concerning extensions label Oct 31, 2019
@sandy081 sandy081 added this to the November 2019 milestone Nov 15, 2019
@mjbvz mjbvz added the verified Verification succeeded label Dec 4, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions ux User experience issues verified Verification succeeded
Projects
None yet
Milestone
November 2019
Development

No branches or pull requests
5 participants
@joaomoreno @patrys @isidorn @sandy081 @mjbvz