After accepting suggestion with "overwriteOnAccept" one (next) char is removed

[svipas]

• VSCode Version: 1.40.0 (29ffbfe3f1c21b01a2d0670170855669dd2b3b4f)
• OS Version: macOS

Steps to Reproduce:

1. Add "editor.suggest.overwriteOnAccept": true in settings.
2. Use suggestion widget to auto-complete existing code and you will see that very often it will remove next char.

For e.g. write document.() and move cursor between . and ( and try to auto-complete something for e.g. getAnimations instead of document.getAnimations() you will get document.getAnimations)

Remember this happens often, but not every time, just try and I'm sure you will be able to reproduce the problem.

/cc @jrieken

[jrieken]

I cannot reproduce... (tried with JS)

[jrieken]

never mind - I can reproduce...

[jrieken]

This is actually very similar to #66187. The issue is that the default replace/insert ranges are computed "after" the completion have be computed. If you are either typing fast or if completions are slow then the document contains one more character after completions have been computed. That breaks things. The fix is to compute the default ranges upfront.

[svipas]

Thanks for explaining it and fixing. Good work!

[svipas]

@jrieken Unfortunately issue still exists.

[jrieken]

Unfortunately I cannot use a gif as input. I also wonder what version of TypeScript (I assume) offers word base suggestions at that place? Is that an extension?

[svipas]

I'm using JavaScript and TypeScript Nightly (3.8.20191026) extension with VS Code insiders.

interface CheckoutOrderDetailsProps {
  data: CartItem[];
  currencyCode: CurrencyCode;
  languageCode: LanguageEnum;
  totalPrice: string;
  children?: ReactNode;
}

[jrieken]

I stil don't see word based suggests there. Sure that there is no other extension involved?

[svipas]

Yes.

[svipas]

@jrieken I know how to reproduce it.

interface Props {
  totalPrice: string;
}

const totalPrice = `${totalPrice}`

Try now to remove totalPrice from interface and use auto-complete. You need to do that several times, because it's a little bit harder to repro, but still possible like earlier.

[jrieken]

Try now to remove totalPrice from interface and use auto-complete.

Not sure what that means. Can provide step by step what you are doing?

[svipas]

1. Create a new Untitled TS file.

2. Copy-paste this:

interface Props {
  totalPrice: string;
}

const totalPrice = `${totalPrice}`

3. Remove totalPrice from interface to look like this:

interface Props {
 : string;
}

const totalPrice = `${totalPrice}`

4. Use suggestion widget to auto-complete the totalPrice near : string.

Try 3 and 4 step several times.

GIF:

[jrieken]

idk what's going on here, I don't get word based suggestions because typescript always proposed readonly which then mutes word based suggestions. Any change you have those filtered?

Anyways, I do have a theory. This is the same problem just in a different place. Word based suggestions are computed on a web worker (not on the extension host process) and there we have the same problem: first suggestions, then defaults are computed and therefore words from a later state are used.

[jrieken]

Pushed another change. Next try tomorrow

[svipas]

I'm using VS Code Insiders (b7b21844e760e632f39bedf651da2bc93f54b0cc) with extensions mentioned above. I don't have any custom configurations, etc.

Thanks, I will try to test it tomorrow.

[svipas]

I don't know if this helps in any case, but seems I don't get kind 17 or label readonly.

[jrieken]

That's just the first round: It's usually snippets, then extensions (TS in this case), then and only when the former didn't produce a result it's word-suggestions

[aeschli]

Feature that caused the issue got reverted.