Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web: Buttons in notification area are cropped off with enough space #83573

Closed
octref opened this issue Oct 29, 2019 · 2 comments
Closed

Web: Buttons in notification area are cropped off with enough space #83573

octref opened this issue Oct 29, 2019 · 2 comments
Assignees
@bpasero
Labels
bug Issue identified by VS Code Team member as probable bug firefox Issues running VSCode in Web on Firefox verified Verification succeeded web Issues related to running VSCode in the web
Milestone
October 2019

Comments

@octref
Copy link
Contributor

octref commented Oct 29, 2019

Testing #83296:

Visual Studio Code - Insiders
Version: 1.40.0-insider
Commit: b7b2184
Date: 2019-10-29T06:38:51.389Z
Browser: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:70.0) Gecko/20100101 Firefox/70.0

  1. Open vscode repo (or any large repo)
  2. See the "unable to watch file changes in this large workspace..." message
  3. Notice the button is cropped

image
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug firefox Issues running VSCode in Web on Firefox web Issues related to running VSCode in the web labels Oct 30, 2019
@bpasero bpasero added this to the October 2019 milestone Oct 30, 2019
@bpasero
Copy link
Member

bpasero commented Oct 30, 2019

Saw this as well in @sbatten custom dialogs. So possibly the fix for buttons would fix this everywhere.

@bpasero bpasero changed the title Test Web: Buttons in notification area are cropped off with enough space Web: Buttons in notification area are cropped off with enough space Oct 30, 2019
bpasero added a commit that referenced this issue Oct 30, 2019
@bpasero
better fix #83573
557cf01
@bpasero bpasero mentioned this issue Oct 30, 2019
Closed
@joaomoreno
Copy link
Member

Verified in dev.

@joaomoreno joaomoreno added the verified Verification succeeded label Oct 30, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug firefox Issues running VSCode in Web on Firefox verified Verification succeeded web Issues related to running VSCode in the web
Projects
None yet
Milestone
October 2019
Development

No branches or pull requests
3 participants
@joaomoreno @bpasero @octref