Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web: Listen to pointer events for assistive touch devices #83719

Closed
rebornix opened this issue Oct 31, 2019 · 2 comments
Closed

Web: Listen to pointer events for assistive touch devices #83719

rebornix opened this issue Oct 31, 2019 · 2 comments
Assignees
@rebornix
Labels
ios-ipados safari Issues running VSCode in Web on Safari web Issues related to running VSCode in the web
Milestone
November 2019

Comments

@rebornix
Copy link
Member

Re #83296

Currently we listen to mousemove/out/enter/ events in quite a few places (global, list view, editor, etc) but we never listen to pointer events.

On iOS/iPadOS, pointer events are triggered by Pencil, Mouse or Touch and PointerEvent is subclass of MouseEvent so at least we can listen to PointerEvents for iOS/iPadOS.

We can also look into how other browsers behave with pointer events on devices with touch screens and see if this logic can be generic.
@rebornix rebornix self-assigned this Oct 31, 2019
@rebornix rebornix added web Issues related to running VSCode in the web ios-ipados labels Oct 31, 2019
This was referenced Oct 31, 2019
Closed
Closed
Closed
@bpasero
Copy link
Member

bpasero commented Oct 31, 2019

Drag and drop works really well for me in Chrome on iPadOS. So they must be emulating the proper events that it works for us.

@rebornix
Copy link
Member Author

Good to know that, then we can cross compare the events emitted from Safari and Chrome to achieve the same behavior.

@rebornix rebornix added the safari Issues running VSCode in Web on Safari label Nov 14, 2019
rebornix added a commit that referenced this issue Nov 14, 2019
@rebornix
Fix #83719. Trigger Context Menu in Editor with touch.
3180eaf
@rebornix rebornix added this to the November 2019 milestone Nov 14, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rebornix rebornix

Labels
ios-ipados safari Issues running VSCode in Web on Safari web Issues related to running VSCode in the web
Projects
None yet
Milestone
November 2019
Development

No branches or pull requests
2 participants
@rebornix @bpasero