Portable tmp should set %tmp% also

[gilescope]

It’s great that having a data/tmp dir redirects the %TEMP% env var, but it would be great if it also redirects %TMP% also as building unix-like stuff on windows can often rely on %tmp%.

By setting both you cover all cases and have happier users as more stuff works first time.

[joaomoreno]

This sounds like a feature for terminal, tasks & debug, or wherever we spawn processes from.

[Tyriar]

@joaomoreno doesn't it make more sense to set this on the main process' environment instead of special casing something for portable in several different features?

[joaomoreno]

🤔 My bad... this is actually implemented:

vscode/src/bootstrap.js

Line 266 in 109c519

process.env[process.platform === 'win32' ? 'TEMP' : 'TMPDIR'] = portableTempPath;

@gilescope In Windows, the TEMP directory should be redirected, don't you see that behavior?

[gilescope]

I do see TEMP dir is redirected. cargo install cargo-watch is what's running foul and digging into the issue it seems that rust checks 'TMP' env before checking 'TEMP'. It does this in accordence with: https://docs.microsoft.com/en-gb/windows/win32/api/fileapi/nf-fileapi-gettemppatha

My suggestion for peace and harmony is to remove the OS check and redirect both TMP and TEMP on all OSes.

[gilescope]

Thank you - much appreciated!

…

On Mon, 11 Nov 2019 at 10:57, João Moreno ***@***.***> wrote: Closed #83998 <#83998> via 545e066 <545e066> . — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#83998?email_source=notifications&email_token=AAGEJCEEUTCOUDAIHQXO7D3QTE3CFA5CNFSM4JJE4BYKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOUYS7SGI#event-2787506457>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGEJCD6A2UKP5IXJPGGIUTQTE3CFANCNFSM4JJE4BYA> .