Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quick Open: Scroll position is wrong when opening #84125

Closed
joaomoreno opened this issue Nov 7, 2019 · 4 comments
Closed

Quick Open: Scroll position is wrong when opening #84125

joaomoreno opened this issue Nov 7, 2019 · 4 comments
Assignees
@chrmarti
Labels
bug Issue identified by VS Code Team member as probable bug quick-pick Quick-pick widget issues verified Verification succeeded
Milestone
November 2019

Comments

@joaomoreno
Copy link
Member

  1. Run Git: Checkout to...
  2. Press Enter to accept Create new branch...
  3. Press Escape to close quick open
  4. Run Git: Checkout to... again

The view is scrolled down by one row, hiding the first option:

image
@joaomoreno
Copy link
Member Author

Not sure who to assign this to, please correct me if needed.

@chrmarti
Copy link
Contributor

chrmarti commented Nov 7, 2019

Not a regression.

@chrmarti chrmarti added this to the November 2019 milestone Nov 7, 2019
@chrmarti chrmarti added bug Issue identified by VS Code Team member as probable bug quick-pick Quick-pick widget issues labels Nov 7, 2019
@gjsjohnmurray gjsjohnmurray mentioned this issue Nov 7, 2019
Closed
@jeanp413
Copy link
Contributor

  1. Selecting Create new branch... shows a quickInputBox which sets display: none to the quickInputList
  2. Selecting Git: Checkout to... will do all the quickInputList layout calculations with display: none set and change to display: '' at the end.
    During the layout calculations trySelectFirst is called which calls reveal from listWidget and inside this function this.view.renderHeight will return 0 incorrectly because the container has display: none set.

Moving this.ui.setVisibilities to the top seems to fix the issue

@chrmarti
Copy link
Contributor

@jeanp413 Thanks for the analysis. Going with that. 👍

chrmarti added a commit that referenced this issue Nov 12, 2019
@chrmarti
Only update visibilities when visible (#84125)
57ddcfd
@RMacfarlane RMacfarlane added the verified Verification succeeded label Dec 4, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chrmarti chrmarti

Labels
bug Issue identified by VS Code Team member as probable bug quick-pick Quick-pick widget issues verified Verification succeeded
Projects
None yet
Milestone
November 2019
Development

No branches or pull requests
5 participants
@joaomoreno @RMacfarlane @chrmarti @jeanp413 @alexr00