Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable breadcrumbs for unsaved files #84746

Open
giggio opened this issue Nov 13, 2019 · 7 comments
Open

Enable breadcrumbs for unsaved files #84746

giggio opened this issue Nov 13, 2019 · 7 comments
Assignees
@jrieken
Labels
breadcrumbs feature-request Request for new features or functionality workbench-untitled-editors Managing of untitled editors in workbench window
Milestone
Backlog

Comments

@giggio
Copy link

giggio commented Nov 13, 2019

Right now breadcrumbs for files (json, yaml, etc) only work if the file is saved. If I add a new file (File > New File), and set the language mode, the breadcrumbs should show the file structure without the file path part.
@vscodebot
Copy link

vscodebot bot commented Nov 13, 2019

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@jrieken jrieken added breadcrumbs feature-request Request for new features or functionality labels Nov 14, 2019
@sohailrajdev97
Copy link
Member

@jrieken. I would like to work on this. Any leads would be appreciated.

@jrieken
Copy link
Member

jrieken commented Nov 14, 2019

Check out the change for this #74924 - which was basically about disabling breadcrumbs for untitled files. I believe this issue will boil down to being a duplicate of #56327 which is about not showing an empty breadcrumbs. The tricky issue is that you don't know that breadcrumbs are going to empty at the time of the editor being initialised and that we also want to keep hiding/showing breadcrumbs to a minimum.

@JacksonKearl
Copy link
Contributor

This would help for Search Editors - I assign each results block from a file that file name as a symbol, and when the file is saved a user can use the breadcrumbs to determine the file a given result lives in if it would otherwise be offscreen. Here I have a saved search that shows I'm at src/vs/loader.js, but often the Editors never get saved.

image

@jrieken jrieken added this to the Backlog milestone Jan 13, 2020
@avicenna-developer avicenna-developer mentioned this issue Apr 25, 2020
Closed
@bpasero bpasero added the workbench-untitled-editors Managing of untitled editors in workbench window label May 21, 2021
@tjx666

This comment was marked as spam.

Sign in to view
@Weilet
Copy link

Weilet commented Nov 18, 2022

Any progress on this topic would be greatly appreciated.
I use vscode as a json viewer sometimes and breadcrumbs can make it more efficient.

@shtratos shtratos mentioned this issue Nov 24, 2023
Closed
orgads added a commit to orgads/vscode that referenced this issue Dec 6, 2023
@orgads
Show breadcrumbs also for untitled files
559629f 
Breadcrumbs used to be enabled for untitled files (microsoft#54094, 9768dab).
Following a complain about having an empty bar (microsoft#74924), it was removed
(microsoft#75325).

This change enables breadcrumbs for new files, but only if the language
is not plaintext. So for a completely new file without contents nothing
is shown, but when a language is detected/chosen it will appear.

Fixes microsoft#84746.
@orgads orgads mentioned this issue Dec 7, 2023
Closed
orgads added a commit to orgads/vscode that referenced this issue Dec 7, 2023
@orgads
Show breadcrumbs also for untitled files
2e6133d 
Breadcrumbs used to be enabled for untitled files (microsoft#54094, 9768dab).
Following a complain about having an empty bar (microsoft#74924), it was removed
(microsoft#75325).

This change enables breadcrumbs for new files, but only if the language
is not plaintext. So for a completely new file without contents nothing
is shown, but when a language is detected/chosen it will appear.

Fixes microsoft#84746.
orgads added a commit to orgads/vscode that referenced this issue Dec 15, 2023
@orgads
Show breadcrumbs also for untitled files
7462540 
Breadcrumbs used to be enabled for untitled files (microsoft#54094, 9768dab).
Following a complain about having an empty bar (microsoft#74924), it was removed
(microsoft#75325).

This change enables breadcrumbs for new files, but only if the language
is not plaintext. So for a completely new file without contents nothing
is shown, but when a language is detected/chosen it will appear.

Fixes microsoft#84746.
orgads added a commit to orgads/vscode that referenced this issue Dec 15, 2023
@orgads
Show breadcrumbs also for untitled files
2b50367 
Breadcrumbs used to be enabled for untitled files (microsoft#54094, 9768dab).
Following a complain about having an empty bar (microsoft#74924), it was removed
(microsoft#75325).

This change enables breadcrumbs for new files, but only if the language
is not plaintext. So for a completely new file without contents nothing
is shown, but when a language is detected/chosen it will appear.

Fixes microsoft#84746.
orgads added a commit to orgads/vscode that referenced this issue Dec 19, 2023
@orgads
Show breadcrumbs also for untitled files
8a28824 
Breadcrumbs used to be enabled for untitled files (microsoft#54094, 9768dab).
Following a complain about having an empty bar (microsoft#74924), it was removed
(microsoft#75325).

This change enables breadcrumbs for new files, but only if the language
is not plaintext. So for a completely new file without contents nothing
is shown, but when a language is detected/chosen it will appear.

Fixes microsoft#84746.
orgads added a commit to orgads/vscode that referenced this issue Jan 12, 2024
@orgads
Show breadcrumbs also for untitled files
0071267 
Breadcrumbs used to be enabled for untitled files (microsoft#54094, 9768dab).
Following a complain about having an empty bar (microsoft#74924), it was removed
(microsoft#75325).

This change enables breadcrumbs for new files, but only if the language
is not plaintext. So for a completely new file without contents nothing
is shown, but when a language is detected/chosen it will appear.

Fixes microsoft#84746.
@orgads
Copy link
Contributor

orgads commented Jan 12, 2024

I pushed #200228 a month ago, but it didn't get any attention 😐

orgads added a commit to orgads/vscode that referenced this issue Jan 14, 2024
@orgads
Show breadcrumbs also for untitled files
4607c98 
Breadcrumbs used to be enabled for untitled files (microsoft#54094, 9768dab).
Following a complain about having an empty bar (microsoft#74924), it was removed
(microsoft#75325).

This change enables breadcrumbs for new files, but only if the language
server supports outline, and there is content in the editor.

Fixes microsoft#84746.
orgads added a commit to orgads/vscode that referenced this issue Jan 14, 2024
@orgads
Show breadcrumbs also for untitled files
5780f2b 
Breadcrumbs used to be enabled for untitled files (microsoft#54094, 9768dab).
Following a complain about having an empty bar (microsoft#74924), it was removed
(microsoft#75325).

This change enables breadcrumbs for new files, but only if the language
server supports outline, and there is content in the editor.

Fixes microsoft#84746.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrieken jrieken

Labels
breadcrumbs feature-request Request for new features or functionality workbench-untitled-editors Managing of untitled editors in workbench window
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Show breadcrumbs also for untitled files orgads/vscode
8 participants
@giggio @bpasero @orgads @jrieken @JacksonKearl @sohailrajdev97 @Weilet @tjx666